perf: optimize trace decoding by making identity fetching non-blocking

[mattsse]

Component

Forge

Describe the feature you would like

Ref #3006

Decoding traces for better output can make use of etherscan or sig.eth.samczsun.com

both require API requests, the tracing decoding is currently blocking, which means we have code that looks like:

foundry/evm/src/trace/identifier/etherscan.rs

Line 86 in 9035623

RuntimeOrHandle::new().block_on(fut)

we could solve this by making everything async or use a background task with channels instead

since there's only 1 identifier for the entire suit, the latter makes sense, this way we still keep the non async test interface but can use async decoding

Additional context

No response

[gakonst]

agree

[zerosnacks]

Correct me if I'm wrong but I think this is still the case though the code has been updated since:

foundry/crates/evm/traces/src/identifier/etherscan.rs

Lines 134 to 150 in 626221f

	let fetched_identities = foundry_common::block_on(
	fetcher
	.map(|(address, metadata)| {
	let label = metadata.contract_name.clone();
	let abi = metadata.abi().ok().map(Cow::Owned);
	self.contracts.insert(address, metadata);
	AddressIdentity {
	address,
	label: Some(label.clone()),
	contract: Some(label),
	abi,
	artifact_id: None,
	}
	})
	.collect::<Vec<AddressIdentity<'_>>>(),
	);

Leaving it open but low priority as this is only really an issue on an initial run, after that the identifiers are loaded from cache.