Replace #[allow()] with #[expect()] (#10131)

* Replace `#[allow()]` with `#[expect()]`

* Remove unfulfilled `#[expect()]` and revert one that can't be changed

* Revert to allow[()] on large enums

* Keep `#[expect()]`` on large enums

* Keep `#[expect()]` on large enums

* Fix all CI

* Fix all CI

* Fix all CI

* Replace #[expect()] with #[allow()]

* Fix CI failure

---------

Co-authored-by: grandizzy <[email protected]>

Author: 0xMushow

crates/anvil/core/src/eth/mod.rs

@@ -36,7 +36,7 @@ pub struct Params<T: Default> {
 /// Represents ethereum JSON-RPC API
 #[derive(Clone, Debug, serde::Deserialize)]
 #[serde(tag = "method", content = "params")]
-#[allow(clippy::large_enum_variant)]
+#[expect(clippy::large_enum_variant)]
 pub enum EthRequest {
     #[serde(rename = "web3_clientVersion", with = "empty_params")]
     Web3ClientVersion(()),

crates/anvil/core/src/eth/serde_helpers.rs

@@ -1,6 +1,5 @@
 //! custom serde helper functions
 
-#[allow(dead_code)]
 pub mod sequence {
     use serde::{
         de::DeserializeOwned, ser::SerializeSeq, Deserialize, Deserializer, Serialize, Serializer,

crates/anvil/core/src/types.rs

@@ -36,8 +36,8 @@ pub struct ReorgOptions {
 }
 
 #[derive(Debug, Clone, Deserialize)]
-#[allow(clippy::large_enum_variant)]
 #[serde(untagged)]
+#[expect(clippy::large_enum_variant)]
 pub enum TransactionData {
     JSON(TransactionRequest),
     Raw(Bytes),

crates/anvil/src/eth/api.rs

@@ -133,7 +133,7 @@ pub struct EthApi {
 
 impl EthApi {
     /// Creates a new instance
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     pub fn new(
         pool: Arc<Pool>,
         backend: Arc<backend::mem::Backend>,
@@ -2803,7 +2803,7 @@ impl EthApi {
     }
 
     /// Returns the first signer that can sign for the given address
-    #[allow(clippy::borrowed_box)]
+    #[expect(clippy::borrowed_box)]
     pub fn get_signer(&self, address: Address) -> Option<&Box<dyn Signer>> {
         self.signers.iter().find(|signer| signer.is_signer_for(address))
     }

crates/anvil/src/eth/backend/mem/mod.rs

@@ -213,7 +213,7 @@ pub struct Backend {
 
 impl Backend {
     /// Initialises the balance of the given accounts
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     pub async fn with_genesis(
         db: Arc<AsyncRwLock<Box<dyn Db>>>,
         env: Arc<RwLock<EnvWithHandlerCfg>>,
@@ -1022,7 +1022,7 @@ impl Backend {
     }
 
     /// Creates an EVM instance with optionally injected precompiles.
-    #[allow(clippy::type_complexity)]
+    #[expect(clippy::type_complexity)]
     fn new_evm_with_inspector_ref<'i, 'db>(
         &self,
         db: &'db dyn DatabaseRef<Error = DatabaseError>,
@@ -2876,7 +2876,6 @@ impl TransactionValidator for Backend {
 }
 
 /// Creates a `AnyRpcTransaction` as it's expected for the `eth` RPC api from storage data
-#[allow(clippy::too_many_arguments)]
 pub fn transaction_build(
     tx_hash: Option<B256>,
     eth_transaction: MaybeImpersonatedTransaction,

crates/anvil/src/eth/backend/mem/storage.rs

@@ -350,7 +350,6 @@ impl BlockchainStorage {
         self.best_number = U64::from(block_number);
     }
 
-    #[allow(unused)]
     pub fn empty() -> Self {
         Self {
             blocks: Default::default(),

crates/anvil/src/service.rs

@@ -94,7 +94,6 @@ impl Future for NodeService {
             let filters = pin.filters.clone();
 
             // evict filters that timed out
-            #[allow(clippy::redundant_async_block)]
             tokio::task::spawn(async move { filters.evict().await });
         }
 

crates/anvil/tests/it/eip4844.rs

@@ -205,7 +205,7 @@ async fn can_check_blob_fields_on_genesis() {
     assert_eq!(block.header.excess_blob_gas, Some(0));
 }
 
-#[allow(clippy::disallowed_macros)]
+#[expect(clippy::disallowed_macros)]
 #[tokio::test(flavor = "multi_thread")]
 async fn can_correctly_estimate_blob_gas_with_recommended_fillers() {
     let node_config = NodeConfig::test().with_hardfork(Some(EthereumHardfork::Cancun.into()));
@@ -248,7 +248,7 @@ async fn can_correctly_estimate_blob_gas_with_recommended_fillers() {
     );
 }
 
-#[allow(clippy::disallowed_macros)]
+#[expect(clippy::disallowed_macros)]
 #[tokio::test(flavor = "multi_thread")]
 async fn can_correctly_estimate_blob_gas_with_recommended_fillers_with_signer() {
     let node_config = NodeConfig::test().with_hardfork(Some(EthereumHardfork::Cancun.into()));

crates/anvil/tests/it/fork.rs

@@ -28,15 +28,15 @@ const DEAD_BALANCE_AT_BLOCK_NUMBER: u128 = 12_556_069_338_441_120_059_867u128;
 const BLOCK_TIMESTAMP: u64 = 1_650_274_250u64;
 
 /// Represents an anvil fork of an anvil node
-#[allow(unused)]
+#[expect(unused)]
 pub struct LocalFork {
     origin_api: EthApi,
     origin_handle: NodeHandle,
     fork_api: EthApi,
     fork_handle: NodeHandle,
 }
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 impl LocalFork {
     /// Spawns two nodes with the test config
     pub async fn new() -> Self {

crates/anvil/tests/it/main.rs

@@ -22,7 +22,6 @@ mod txpool;
 pub mod utils;
 mod wsapi;
 
-#[allow(unused)]
 pub(crate) fn init_tracing() {
     let _ = tracing_subscriber::FmtSubscriber::builder()
         .with_env_filter(tracing_subscriber::EnvFilter::from_default_env())