add legacy option to SendTx (#626)

Author: brockelmore

cast/src/lib.rs

@@ -74,8 +74,9 @@ where
         chain: Chain,
         etherscan_api_key: Option<String>,
     ) -> Result<String> {
-        let (tx, func) =
-            self.build_tx(from, to, Some(args), None, None, None, chain, etherscan_api_key).await?;
+        let (tx, func) = self
+            .build_tx(from, to, Some(args), None, None, None, chain, etherscan_api_key, false)
+            .await?;
         let res = self.provider.call(&tx, None).await?;
 
         // decode args into tokens
@@ -133,7 +134,7 @@ where
     /// let gas = U256::from_str("200000").unwrap();
     /// let value = U256::from_str("1").unwrap();
     /// let nonce = U256::from_str("1").unwrap();
-    /// let data = cast.send(from, to, Some((sig, args)), Some(gas), Some(value), Some(nonce), Chain::Mainnet, None).await?;
+    /// let data = cast.send(from, to, Some((sig, args)), Some(gas), Some(value), Some(nonce), Chain::Mainnet, None, false).await?;
     /// println!("{}", *data);
     /// # Ok(())
     /// # }
@@ -149,9 +150,11 @@ where
         nonce: Option<U256>,
         chain: Chain,
         etherscan_api_key: Option<String>,
+        legacy: bool,
     ) -> Result<PendingTransaction<'_, M::Provider>> {
-        let (tx, _) =
-            self.build_tx(from, to, args, gas, value, nonce, chain, etherscan_api_key).await?;
+        let (tx, _) = self
+            .build_tx(from, to, args, gas, value, nonce, chain, etherscan_api_key, legacy)
+            .await?;
         let res = self.provider.send_transaction(tx, None).await?;
 
         Ok::<_, eyre::Error>(res)
@@ -212,8 +215,9 @@ where
         chain: Chain,
         etherscan_api_key: Option<String>,
     ) -> Result<U256> {
-        let (tx, _) =
-            self.build_tx(from, to, args, None, value, None, chain, etherscan_api_key).await?;
+        let (tx, _) = self
+            .build_tx(from, to, args, None, value, None, chain, etherscan_api_key, false)
+            .await?;
         let res = self.provider.estimate_gas(&tx).await?;
 
         Ok::<_, eyre::Error>(res)
@@ -230,6 +234,7 @@ where
         nonce: Option<U256>,
         chain: Chain,
         etherscan_api_key: Option<String>,
+        legacy: bool,
     ) -> Result<(TypedTransaction, Option<ethers_core::abi::Function>)> {
         let from = match from.into() {
             NameOrAddress::Name(ref ens_name) => self.provider.resolve_name(ens_name).await?,
@@ -245,7 +250,7 @@ where
         };
 
         // make the call
-        let mut tx: TypedTransaction = if chain.is_legacy() {
+        let mut tx: TypedTransaction = if chain.is_legacy() || legacy {
             TransactionRequest::new().from(from).to(to).into()
         } else {
             Eip1559TransactionRequest::new().from(from).to(to).into()

cli/src/cast.rs

@@ -176,7 +176,7 @@ async fn main() -> eyre::Result<()> {
             let provider = Provider::try_from(rpc_url)?;
             println!("{}", Cast::new(&provider).transaction(hash, field, to_json).await?)
         }
-        Subcommands::SendTx { eth, to, sig, cast_async, args, gas, value, nonce } => {
+        Subcommands::SendTx { eth, to, sig, cast_async, args, gas, value, nonce, legacy } => {
             let provider = Provider::try_from(eth.rpc_url()?)?;
             let chain_id = Cast::new(&provider).chain_id().await?;
 
@@ -194,6 +194,7 @@ async fn main() -> eyre::Result<()> {
                             eth.chain,
                             eth.etherscan_api_key,
                             cast_async,
+                            legacy,
                         )
                         .await?;
                     }
@@ -209,6 +210,7 @@ async fn main() -> eyre::Result<()> {
                             eth.chain,
                             eth.etherscan_api_key,
                             cast_async,
+                            legacy,
                         )
                         .await?;
                     }
@@ -224,6 +226,7 @@ async fn main() -> eyre::Result<()> {
                             eth.chain,
                             eth.etherscan_api_key,
                             cast_async,
+                            legacy,
                         )
                         .await?;
                     }
@@ -241,6 +244,7 @@ async fn main() -> eyre::Result<()> {
                     eth.chain,
                     eth.etherscan_api_key,
                     cast_async,
+                    legacy,
                 )
                 .await?;
             }
@@ -599,6 +603,7 @@ async fn cast_send<M: Middleware, F: Into<NameOrAddress>, T: Into<NameOrAddress>
     chain: Chain,
     etherscan_api_key: Option<String>,
     cast_async: bool,
+    legacy: bool,
 ) -> eyre::Result<()>
 where
     M::Error: 'static,
@@ -609,7 +614,7 @@ where
     let params = args.1;
     let params = if !sig.is_empty() { Some((&sig[..], params)) } else { None };
     let pending_tx =
-        cast.send(from, to, params, gas, value, nonce, chain, etherscan_api_key).await?;
+        cast.send(from, to, params, gas, value, nonce, chain, etherscan_api_key, legacy).await?;
     let tx_hash = *pending_tx;
 
     if cast_async {

cli/src/opts/cast.rs

@@ -189,6 +189,11 @@ pub enum Subcommands {
         cast_async: bool,
         #[clap(flatten)]
         eth: EthereumOpts,
+        #[clap(
+            long,
+            help = "use legacy transactions instead of EIP1559 ones. this is auto-enabled for common networks without EIP1559"
+        )]
+        legacy: bool,
     },
     #[clap(name = "publish")]
     #[clap(about = "Publish a raw transaction to the network")]