Skip to content

Commit 6ffca0c

Browse files
authored
FIX: discourse-doctor plugin check too loose (discourse#478)
The non-official plugin check was looking only for `git`, which would match other things in the yml file (e.g., a digital ocean S3 bucket name). `grep` for `'git clone'` should solve that problem. Though I did test this edit on a running sitee, I made these edit in the web interface by hand rather than pushing a commit where I tested it. Please look twice to make sure that I didn't do something silly when making the edit here.
1 parent 6e6ec68 commit 6ffca0c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

discourse-doctor

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ get_discourse_config() {
185185

186186
check_plugins() {
187187
log -e "\n\n==================== PLUGINS ===================="
188-
log -e "$(grep git containers/$app_name.yml)"
188+
log -e "$(grep 'git clone' containers/$app_name.yml)"
189189
grep git containers/$app_name.yml > /tmp/$PPID.grep
190190

191191
if grep -cv "github.com/discourse" /tmp/$PPID.grep > /dev/null

0 commit comments

Comments
 (0)