Fix I2C_CommandReadBulk reading one byte too many

bessman · bessman · commit 4ea85ec9ecda · 2024-07-30T11:27:11.000+02:00
diff --git a/src/bus/i2c/i2c.c b/src/bus/i2c/i2c.c
@@ -768,7 +768,7 @@ response_t I2C_CommandReadBulk(void) {
     I2C_RestartSignal();
     I2C_Transmit((device << 1) | 1);
 
-    for (uint8_t i = 1; i < count; ++i) {
+    while (--count) {
         UART1_Write(I2C_Receive(I2C_RESPONSE_ACKNOWLEDGE));
     }
     UART1_Write(I2C_Receive(I2C_RESPONSE_NEGATIVE_ACKNOWLEDGE));

Original file line number	Diff line number	Diff line change
`@@ -768,7 +768,7 @@ response_t I2C_CommandReadBulk(void) {`
`768`	`768`	`I2C_RestartSignal();`
`769`	`769`	`I2C_Transmit((device << 1) \| 1);`
`770`	`770`
`771`		`- for (uint8_t i = 1; i < count; ++i) {`
	`771`	`+ while (--count) {`
`772`	`772`	`UART1_Write(I2C_Receive(I2C_RESPONSE_ACKNOWLEDGE));`
`773`	`773`	`}`
`774`	`774`	`UART1_Write(I2C_Receive(I2C_RESPONSE_NEGATIVE_ACKNOWLEDGE));`