resolve comments

Author: Aqil-Ahmad

app/eventyay/base/migrations/0005_user_is_wikimedia_user.py

@@ -13,4 +13,9 @@ class Migration(migrations.Migration):
             name='is_wikimedia_user',
             field=models.BooleanField(default=False, verbose_name='Is Wikimedia user'),
         ),
+        migrations.AlterField(
+            model_name='user',
+            name='wikimedia_username',
+            field=models.CharField(max_length=255, blank=True, null=True, unique=True, verbose_name='Wikimedia username'),
+        ),
     ]

app/eventyay/base/models/auth.py

@@ -164,7 +164,7 @@ class UserType(models.TextChoices):
         unique=True, db_index=True, null=True, blank=True, verbose_name=_('E-mail'), max_length=190
     )
     fullname = models.CharField(max_length=255, blank=True, null=True, verbose_name=_('Full name'))
-    wikimedia_username = models.CharField(max_length=255, blank=True, null=True, verbose_name=_('Wikimedia username'))
+    wikimedia_username = models.CharField(max_length=255, blank=True, null=True, unique=True, verbose_name=_('Wikimedia username'))
     is_wikimedia_user = models.BooleanField(default=False, verbose_name=_('Is Wikimedia user'))
     is_active = models.BooleanField(default=True, verbose_name=_('Is active'))
     is_staff = models.BooleanField(default=False, verbose_name=_('Is site admin'))

app/eventyay/presale/forms/checkout.py

@@ -99,10 +99,7 @@ def clean(self):
         if self.request and self.request.user and is_wikimedia_user(self.request.user):
             return cleaned_data
 
-        # For non-Wikimedia users, validate email is provided
-        if not cleaned_data.get('email'):
-            raise ValidationError(_('Email is required'))
-
+        # Validate email_repeat matches email if both are provided
         if (
             self.event.settings.order_email_asked_twice
             and self.cleaned_data.get('email')