sh: Check for invalidate argument to fesetround

keith-packard · keith-packard · commit 608e7055f1dd · 2024-04-17T14:40:43.000-07:00
This function needs to return an error for invalid argument and not
change the rounding mode.

Signed-off-by: Keith Packard &lt;keithp@keithp.com&gt;
diff --git a/newlib/libc/machine/sh/machine/fenv-fp.h b/newlib/libc/machine/sh/machine/fenv-fp.h
@@ -148,6 +148,8 @@ __declare_fenv_inline(int) fesetround(int round)
 {
 	fenv_t fpscr;
 
+        if (round & ~_SH_FPU_ROUND_MASK)
+                return (1);
 	_sh_get_fpscr(fpscr);
 	fpscr &= ~(_SH_FPU_ROUND_MASK);
 	fpscr |= round;

Original file line number	Diff line number	Diff line change
`@@ -148,6 +148,8 @@ __declare_fenv_inline(int) fesetround(int round)`
`148`	`148`	`{`
`149`	`149`	`fenv_t fpscr;`
`150`	`150`
	`151`	`+ if (round & ~_SH_FPU_ROUND_MASK)`
	`152`	`+ return (1);`
`151`	`153`	`_sh_get_fpscr(fpscr);`
`152`	`154`	`fpscr &= ~(_SH_FPU_ROUND_MASK);`
`153`	`155`	`fpscr \|= round;`