@@ -1146,8 +1146,8 @@ class Tangerine extends dns.promises.Resolver {
1146
1146
// <https://github.com/nodejs/undici/issues/3353>
1147
1147
// eslint-disable-next-line no-await-in-loop, max-depth
1148
1148
if ( body && typeof body . dump === 'function' ) await body . dump ( ) ;
1149
- // eslint-disable-next-line max-depth
1150
- if ( ! abortController . signal . aborted ) abortController . abort ( ) ;
1149
+ // NOTE: we don't need to do this (causes uncaught exception)
1150
+ // if (!abortController.signal.aborted) abortController.abort();
1151
1151
break ;
1152
1152
}
1153
1153
@@ -1231,7 +1231,8 @@ class Tangerine extends dns.promises.Resolver {
1231
1231
// https://github.com/mafintosh/dns-packet/issues/72
1232
1232
return packet . decode ( buffer ) ;
1233
1233
} catch ( _err ) {
1234
- if ( ! abortController . signal . aborted ) abortController . abort ( ) ;
1234
+ // NOTE: we don't need to do this (causes uncaught exception)
1235
+ // if (!abortController.signal.aborted) abortController.abort();
1235
1236
debug ( _err , { name, rrtype, ecsSubnet } ) ;
1236
1237
if ( this . options . returnHTTPErrors ) throw _err ;
1237
1238
const err = this . constructor . createError (
@@ -1255,7 +1256,13 @@ class Tangerine extends dns.promises.Resolver {
1255
1256
// (instead they are called with "ABORT_ERR"; see ABORT_ERROR_CODES)
1256
1257
cancel ( ) {
1257
1258
for ( const abortController of this . abortControllers ) {
1258
- if ( ! abortController . signal . aborted ) abortController . abort ( ) ;
1259
+ if ( ! abortController . signal . aborted ) {
1260
+ try {
1261
+ abortController . abort ( ) ;
1262
+ } catch ( err ) {
1263
+ this . options . logger . debug ( err ) ;
1264
+ }
1265
+ }
1259
1266
}
1260
1267
}
1261
1268
@@ -1273,7 +1280,11 @@ class Tangerine extends dns.promises.Resolver {
1273
1280
parentAbortController . signal . addEventListener (
1274
1281
'abort' ,
1275
1282
( ) => {
1276
- abortController . abort ( ) ;
1283
+ try {
1284
+ abortController . abort ( ) ;
1285
+ } catch ( err ) {
1286
+ this . options . logger . debug ( err ) ;
1287
+ }
1277
1288
} ,
1278
1289
{ once : true }
1279
1290
) ;
0 commit comments