Apply suggestions from code review

Co-authored-by: Laurence Kedward <[email protected]>

Author: awvwgk

src/fpm_backend.f90

@@ -55,9 +55,6 @@ subroutine build_package(targets,model)
     type(string_t) :: temp
 
     ! Need to make output directory for include (mod) files
-    !if (.not.exists(join_path(model%output_directory,model%package_name))) then
-        !call mkdir(join_path(model%output_directory,model%package_name))
-    !end if
     allocate(build_dirs(0))
     do i = 1, size(targets)
        associate(target => targets(i)%ptr)

src/fpm_targets.f90

@@ -69,10 +69,10 @@ module fpm_targets
     !> File path of build target object relative to cwd
     character(:), allocatable :: output_file
 
-    !> File path of build target object relative to cwd
+    !> File path of build target object relative to output_dir
     character(:), allocatable :: output_name
 
-    !> File path of build target object relative to cwd
+    !> File path of output directory
     character(:), allocatable :: output_dir
 
     !> Primary source for this build target

test/fpm_test/test_module_dependencies.f90

@@ -66,7 +66,6 @@ subroutine test_library_module_use(error)
         type(fpm_model_t) :: model
         type(build_target_ptr), allocatable :: targets(:)
 
-        !model%output_directory = ''
         allocate(model%external_modules(0))
         allocate(model%packages(1))
         allocate(model%packages(1)%sources(2))
@@ -136,7 +135,6 @@ subroutine test_scope(exe_scope,error)
         type(build_target_ptr), allocatable :: targets(:)
         character(:), allocatable :: scope_str
 
-        !model%output_directory = ''
         allocate(model%external_modules(0))
         allocate(model%packages(1))
         allocate(model%packages(1)%sources(2))
@@ -195,7 +193,6 @@ subroutine test_program_with_module(error)
         type(fpm_model_t) :: model
         type(build_target_ptr), allocatable :: targets(:)
 
-        !model%output_directory = ''
         allocate(model%external_modules(0))
         allocate(model%packages(1))
         allocate(model%packages(1)%sources(1))
@@ -249,7 +246,6 @@ subroutine test_scope(exe_scope,error)
         type(build_target_ptr), allocatable :: targets(:)
         character(:), allocatable :: scope_str
 
-        !model%output_directory = ''
         allocate(model%external_modules(0))
         allocate(model%packages(1))
         allocate(model%packages(1)%sources(3))
@@ -309,7 +305,6 @@ subroutine test_missing_library_use(error)
         type(fpm_model_t) :: model
         type(build_target_ptr), allocatable :: targets(:)
 
-        !model%output_directory = ''
         allocate(model%external_modules(0))
         allocate(model%packages(1))
         allocate(model%packages(1)%sources(2))
@@ -337,7 +332,6 @@ subroutine test_missing_program_use(error)
         type(fpm_model_t) :: model
         type(build_target_ptr), allocatable :: targets(:)
 
-        !model%output_directory = ''
         allocate(model%external_modules(0))
         allocate(model%packages(1))
         allocate(model%packages(1)%sources(2))
@@ -364,7 +358,6 @@ subroutine test_invalid_library_use(error)
         type(fpm_model_t) :: model
         type(build_target_ptr), allocatable :: targets(:)
 
-        !model%output_directory = ''
         allocate(model%external_modules(0))
         allocate(model%packages(1))
         allocate(model%packages(1)%sources(2))
@@ -392,7 +385,6 @@ subroutine test_subdirectory_module_use(error)
         type(fpm_model_t) :: model
         type(build_target_ptr), allocatable :: targets(:)
 
-        !model%output_directory = ''
         allocate(model%external_modules(0))
         allocate(model%packages(1))
         allocate(model%packages(1)%sources(2))
@@ -512,7 +504,6 @@ subroutine test_invalid_subdirectory_module_use(error)
         type(fpm_model_t) :: model
         type(build_target_ptr), allocatable :: targets(:)
 
-        !model%output_directory = ''
         allocate(model%external_modules(0))
         allocate(model%packages(1))
         allocate(model%packages(1)%sources(2))