Skip to content

Improve Config/Context API #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jethrogb opened this issue Oct 30, 2018 · 1 comment · Fixed by #128
Closed

Improve Config/Context API #4

jethrogb opened this issue Oct 30, 2018 · 1 comment · Fixed by #128
Assignees
@AdrianCX
Labels
enhancement

Comments

@jethrogb
Copy link
Member

Currently the Config/Context types really only work well when you're able to put everything on a stack somewhere. Using Box/Arc requires lots of unsafe.

See also #3.
@jethrogb
Copy link
Member Author

The Rust OpenSSL bindings use the foreign-types crate. We can consider using that instead of our own current wrapper macros.

This was referenced Aug 22, 2019
Open
Open
@AdrianCX AdrianCX self-assigned this Sep 29, 2020
@AdrianCX AdrianCX mentioned this issue Nov 30, 2020
Merged
bors bot added a commit that referenced this issue Dec 17, 2020
@bors
Merge #128
3cf759a 
128: MbedTLS Reference counted instead of lifetimes r=jethrogb a=AdrianCX

Moving from referene counting allows simpler move to native-tls / hyper.

Arc Changes:
- Each Config/Context/... will hold Arcs towards items it holds pointers to.
- This forces objects to live as long as needed, once no longer used they get destroyed by reference counting.

This allows passing the objects to multiple threads without worrying about lifetime.
I've also added notes why classes are Sync where used. Let me know if I missed any classes.

Usage example of an intermediate mbed-hyper integration is at: 
- https://github.com/fortanix/rust-mbedtls/tree/acruceru/wip-mbed-hyper-v2/mbedtls-hyper/examples/integrations

There I added a crate to wrap hyper - similar to native-tls. (that will be moved to native-tls layer soon)
That crate can be considered an integration test that I will raise a separate PR for.


Edit:

Changes after initial review:
-    Added forward_mbedtls_calloc / forward_mbedtls_free functions so we can pass certificates to and from mbedtls without allocator mismatches/corruptions.
-    Switched to MbedtlsList<Certificate> and Certificate. A MbedtlsBox is pending for this PR as well.
-    Fixed most comments.

Still pending:
-    Update define! macros
-    Add MbedtlsBox<Certificate>


Fixes #1
Partial progress on #3
Fixes #4
Fixes #8
Partially addresses #9

Co-authored-by: Adrian Cruceru <[email protected]>
@bors bors bot closed this as completed in ca38f0f Dec 17, 2020
@bors bors bot closed this as completed in #128 Dec 17, 2020
mcr pushed a commit to mcr/rust-mbedtls that referenced this issue Aug 10, 2023
@algesten
fix parse error when no status text. close fortanix#4
d4d68ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdrianCX AdrianCX

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MbedTLS Reference counted instead of lifetimes fortanix/rust-mbedtls
2 participants
@jethrogb @AdrianCX