Skip to content

Commit 6ded699

Browse files
committed
Revert "mlkem: avx2: update keccakf1600 implementation"
This reverts commit 2ac8b2e.
1 parent 2ac8b2e commit 6ded699

File tree

2 files changed

+112
-148
lines changed

2 files changed

+112
-148
lines changed

src/crypto_kem/mlkem/mlkem768/amd64/avx2/fips202.jinc

+15-15
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ fn __keccak1600_scalar(
162162
s_inlen = inlen;
163163
s_rate = rate;
164164

165-
state = _keccakf1600_(state);
165+
state = _keccakf1600_scalar(state);
166166

167167
inlen = s_inlen;
168168
in = s_in;
@@ -180,7 +180,7 @@ fn __keccak1600_scalar(
180180
s_outlen = outlen;
181181
s_rate = rate;
182182

183-
state = _keccakf1600_(state);
183+
state = _keccakf1600_scalar(state);
184184

185185
out = s_out;
186186
outlen = s_outlen;
@@ -191,7 +191,7 @@ fn __keccak1600_scalar(
191191
s_out = out;
192192
}
193193

194-
state = _keccakf1600_(state);
194+
state = _keccakf1600_scalar(state);
195195
out = s_out;
196196
outlen = s_outlen;
197197

@@ -267,7 +267,7 @@ fn _isha3_256(reg ptr u8[32] out, reg u64 in inlen) -> reg ptr u8[32]
267267
s_ilen = ilen;
268268
s_r8 = r8;
269269

270-
state = _keccakf1600_(state);
270+
state = _keccakf1600_scalar(state);
271271

272272
in = s_in;
273273
ilen = s_ilen;
@@ -277,7 +277,7 @@ fn _isha3_256(reg ptr u8[32] out, reg u64 in inlen) -> reg ptr u8[32]
277277
t8 = 0x06;
278278
state = __add_final_block(state, in, ilen, t8, r8);
279279

280-
state = _keccakf1600_(state);
280+
state = _keccakf1600_scalar(state);
281281

282282
out = s_out;
283283

@@ -315,7 +315,7 @@ fn __isha3_512(reg ptr u8[64] out, reg u64 in, inline int inlen) -> stack u8[64]
315315
s_ilen = ilen;
316316
s_r8 = r8;
317317

318-
state = _keccakf1600_(state);
318+
state = _keccakf1600_scalar(state);
319319

320320
in = s_in;
321321
ilen = s_ilen;
@@ -325,7 +325,7 @@ fn __isha3_512(reg ptr u8[64] out, reg u64 in, inline int inlen) -> stack u8[64]
325325
t8 = 0x06;
326326
state = __add_final_block(state, in, ilen, t8, r8);
327327

328-
state = _keccakf1600_(state);
328+
state = _keccakf1600_scalar(state);
329329

330330
out = s_out;
331331

@@ -361,7 +361,7 @@ fn _shake256_1120_32(reg u64 out, reg u64 in0 in1) {
361361

362362
s_in = in1;
363363

364-
state = _keccakf1600_(state);
364+
state = _keccakf1600_scalar(state);
365365

366366
r8 = SHAKE256_RATE;
367367
ilen = MLKEM_INDCPA_CIPHERTEXTBYTES - (SHAKE256_RATE - MLKEM_SYMBYTES);
@@ -376,7 +376,7 @@ fn _shake256_1120_32(reg u64 out, reg u64 in0 in1) {
376376
s_ilen = ilen;
377377
s_r8 = r8;
378378

379-
state = _keccakf1600_(state);
379+
state = _keccakf1600_scalar(state);
380380

381381
in = s_in;
382382
ilen = s_ilen;
@@ -386,7 +386,7 @@ fn _shake256_1120_32(reg u64 out, reg u64 in0 in1) {
386386
t8 = 0x1f;
387387
state = __add_final_block(state, in, ilen, t8, r8);
388388

389-
state = _keccakf1600_(state);
389+
state = _keccakf1600_scalar(state);
390390

391391
out = s_out;
392392

@@ -422,7 +422,7 @@ fn _shake256_128_33(reg ptr u8[128] out, reg const ptr u8[33] in) -> stack u8[12
422422
state[u8 33] ^= 0x1f;
423423
state[u8 SHAKE256_RATE-1] ^= 0x80;
424424

425-
state = _keccakf1600_(state);
425+
state = _keccakf1600_scalar(state);
426426

427427
out = sout;
428428

@@ -455,7 +455,7 @@ fn _isha3_256_32(reg ptr u8[32] out, reg ptr u8[MLKEM_SYMBYTES] in) -> reg ptr u
455455
state[u8 MLKEM_SYMBYTES] ^= 0x06;
456456
state[u8 SHA3_256_RATE - 1] = 0x80;
457457

458-
state = _keccakf1600_(state);
458+
state = _keccakf1600_scalar(state);
459459

460460
out = s_out;
461461

@@ -489,7 +489,7 @@ fn _sha3_512_64(reg ptr u8[64] out, reg const ptr u8[64] in) -> stack u8[64]
489489

490490
out_s = out;
491491

492-
state = _keccakf1600_(state);
492+
state = _keccakf1600_scalar(state);
493493

494494
out = out_s;
495495

@@ -523,7 +523,7 @@ fn _sha3_512_32(reg ptr u8[64] out, reg const ptr u8[32] in) -> stack u8[64]
523523

524524
out_s = out;
525525

526-
state = _keccakf1600_(state);
526+
state = _keccakf1600_scalar(state);
527527

528528
out = out_s;
529529

@@ -567,7 +567,7 @@ fn _shake128_squeezeblock(reg ptr u64[25] state, reg ptr u8[SHAKE128_RATE] out)
567567
inline int i;
568568

569569
out_s = out;
570-
state = _keccakf1600_(state);
570+
state = _keccakf1600_scalar(state);
571571
out = out_s;
572572

573573
for i = 0 to SHAKE128_RATE/8

0 commit comments

Comments
 (0)