You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 30, 2018. It is now read-only.
Unless this is a really small and insignificant change,
6
+
please make sure that we've discussed it first in
7
+
the issues.
8
+
9
+
-->
10
+
11
+
## What
12
+
13
+
<!-- explain what is being done here -->
14
+
15
+
## Why
16
+
17
+
<!-- explain why it's necessary -->
18
+
19
+
## How
20
+
21
+
<!-- explain how you did it -->
22
+
23
+
For issue # <!-- put your issue number here -->
24
+
25
+
Checklist:
26
+
27
+
*[ ] Follows the commit message [conventions](https://github.com/stevemao/conventional-changelog-angular/blob/master/convention.md)
28
+
*[ ] Is [rebased with master](https://egghead.io/lessons/javascript-how-to-rebase-a-git-pull-request-branch?series=how-to-contribute-to-an-open-source-project-on-github)
29
+
*[ ] Is [only one (maybe two) commits](https://egghead.io/lessons/javascript-how-to-squash-multiple-git-commits)
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+4-2Lines changed: 4 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -29,11 +29,13 @@ with a link to a jsbin that demonstrates the issue with [issue.angular-formly.co
29
29
30
30
## Pull Requests
31
31
32
+
**Working on your first Pull Request?** You can learn how from this *free* series [How to Contribute to an Open Source Project on GitHub](https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github)
33
+
32
34
‼️‼️‼️ 👉**Please follow our commit message conventions** even if you're making a small change! This repository follows the
33
35
[How to Write an Open Source JavaScript Library](https://egghead.io/series/how-to-write-an-open-source-javascript-library)
and [this repo](https://github.com/ajoslin/conventional-changelog/blob/master/conventions/angular.md)
38
+
and [this repo](https://github.com/stevemao/conventional-changelog-angular/blob/master/convention.md)
37
39
to learn more about the commit message conventions.
38
40
39
41
[Watch video](https://www.youtube.com/watch?v=QOchwBm9W-g&list=PLV5CVI1eNcJi7lVVIuNyRhEuck1Z007BH&index=1) (slightly out of date)
@@ -52,7 +54,7 @@ Please do the following:
52
54
2. run `npm start` (if you're on a windows machine, see [this issue](https://github.com/formly-js/angular-formly/issues/305))
53
55
3. write tests & code in ES6 goodness :-)
54
56
4. run `git add src/`
55
-
5. run `npm run commit` and follow the prompt (this ensures that your commit message follows [our conventions](https://github.com/ajoslin/conventional-changelog/blob/master/conventions/angular.md)).
57
+
5. run `npm run commit` and follow the prompt (this ensures that your commit message follows [our conventions](https://github.com/stevemao/conventional-changelog-angular/blob/master/convention.md)).
56
58
6. notice that there's a pre-commit hook that runs to ensure tests pass and coverage doesn't drop to prevent the build from breaking :-)
0 commit comments