Skip to content

Commit c000c35

Browse files
author
Kent C. Dodds
committed
Moving back to ssl because I bought a pro account and allowing configuration of non-ssl bins from contributors
1 parent 632c065 commit c000c35

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

CONTRIBUTING.md

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ We LOVE examples! It's extremely helpful to everyone involved, so yes, please cr
1818
2. Make sure it's awesome and clean
1919
3. Make a PR to [examples.json](https://github.com/formly-js/angular-formly-website/edit/master/examples.json)
2020
- The "jsbinId" is the unique part of the jsbin url ("panovu" is the jsbinId for the template)
21+
- *IMPORTANT*: Unless you're a jsbin pro subscriber, please add `noSSL: true`. Or just [purchase a pro subscription](https://jsbin.com/upgrade) :-)
2122
- Feel free to add "keywords" to the entry, this will make it easier to find
2223
- The "slug" is what will appear in the URL for the example. Make it:
2324
1) easy to remember

app/states/root/children/examples/children/category/children/example/components/directives/fd-jsbin-example.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,16 @@ module.exports = ngModule => {
77
return {
88
restrict: 'E',
99
scope: {
10+
noSsl: '@',
1011
jsbinId: '@'
1112
},
1213
link: function(scope, el) {
14+
const s = scope.noSSL === 'true' ? '' : 's';
1315
el.replaceWith(angular.element(`
1416
<div class="fd-jsbin-example">
1517
<iframe width="100%"
1618
height="100%"
17-
src="http://jsbin.com/${scope.jsbinId}/embed?output">
19+
src="http${s}://jsbin.com/${scope.jsbinId}/embed?output">
1820
</iframe>
1921
</div>
2022
`));

app/states/root/children/examples/children/category/children/example/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div>
22
<div ng-if="vm.example">
33
<h2>{{vm.example.title}}</h2>
4-
<fd-jsbin-example jsbin-id="{{::vm.example.jsbinId}}"></fd-jsbin-example>
4+
<fd-jsbin-example jsbin-id="{{::vm.example.jsbinId}}" no-ssl="{{::vm.example.noSSL}}"></fd-jsbin-example>
55
</div>
66
<div ng-if="!vm.example" style="text-align: center">
77
<h2>

0 commit comments

Comments
 (0)