test(unit): converted the js scaffolder tests to vitest

and re-test drove all of the logic to improve the complexity of the tests for this module. there is
still plenty of opportunity to refactor to simplify, but the tests of the current state feel a lot
more manageable than before

for #452

Author: travi

package.json

@@ -48,7 +48,7 @@
     "watch": "run-s 'build:js -- --watch'",
     "prepack": "run-s build",
     "test:unit": "cross-env NODE_ENV=test c8 run-s test:unit:base",
-    "test:unit:base": "npm-run-all --print-label build --parallel test:unit:mocha test:unit:vitest",
+    "test:unit:base": "npm-run-all --print-label build --parallel test:unit:vitest",
     "test:unit:vitest": "DEBUG=any vitest run",
     "test:unit:mocha": "DEBUG=any mocha 'src/**/*-test.js'"
   },

src/package/scaffolder.js

@@ -1,18 +1,22 @@
 import {info} from '@travi/cli-messages';
 import {writePackageJson} from '@form8ion/javascript-core';
 
+import buildPackageName from './package-name.js';
 import buildPackageDetails from './details.js';
 
 export default async function ({
   projectRoot,
+  projectName,
+  scope,
   dialect,
-  packageName,
   license,
   author,
   description
 }) {
   info('Configuring package.json');
 
+  const packageName = buildPackageName(projectName, scope);
+
   await writePackageJson({
     projectRoot,
     config: await buildPackageDetails({
@@ -24,5 +28,5 @@ export default async function ({
     })
   });
 
-  return {};
+  return {packageName};
 }

src/package/scaffolder.test.js

@@ -1,28 +1,29 @@
 import {writePackageJson} from '@form8ion/javascript-core';
 
-import {afterEach, describe, expect, it, vi} from 'vitest';
+import {describe, expect, it, vi} from 'vitest';
 import any from '@travi/any';
 import {when} from 'jest-when';
 
 import * as buildPackageDetails from './details.js';
+import buildPackageName from './package-name.js';
 import {scaffold} from './index.js';
 
 vi.mock('@form8ion/javascript-core');
-vi.mock('./details');
+vi.mock('./package-name.js');
+vi.mock('./details.js');
 
 describe('package scaffolder', () => {
-  afterEach(() => {
-    vi.clearAllMocks();
-  });
-
   it('should create the package file', async () => {
+    const projectName = any.string();
     const packageName = any.string();
+    const scope = any.word();
     const packageDetails = any.simpleObject();
     const projectRoot = any.string();
     const dialect = any.word();
     const license = any.string();
     const author = any.simpleObject();
     const description = any.sentence();
+    when(buildPackageName).calledWith(projectName, scope).mockReturnValue(packageName);
     when(buildPackageDetails.default).calledWith({
       packageName,
       dialect,
@@ -33,12 +34,13 @@ describe('package scaffolder', () => {
 
     expect(await scaffold({
       projectRoot,
+      projectName,
+      scope,
       dialect,
-      packageName,
       license,
       author,
       description
-    })).toEqual({});
+    })).toEqual({packageName});
     expect(writePackageJson).toHaveBeenCalledWith({projectRoot, config: packageDetails});
   });
 });