Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

motifSimilarity (former clusterPWMs) features #23

Open
mbstadler opened this issue Jun 24, 2019 · 2 comments
Open

motifSimilarity (former clusterPWMs) features #23

mbstadler opened this issue Jun 24, 2019 · 2 comments

Comments

@mbstadler
Copy link
Collaborator

mbstadler commented Jun 24, 2019

Currently, clusterPWMs accepts only motifs from a file and requires an output file name (outfile argument).

What about extending clusterPWMs to:

  • have multiple methods (along the line of findMotifHits), e.g. one for motifs in a file, and another for motifs as a PFMatrixList
  • set the default for outfile = NULL and in that case, captures the homer output in a temporary file that will be deleted after parsing. Providing a value for outfile will still work as it does currently
  • make use of the -cpu flag to speed up computations

Finally, what about:

  • porting compareMotifs.pl to R (maybe C++) so that it will run fast enough to make it a default when creating a SummarizedExperiment - the information seems very useful and might be worth to have always available
@mbstadler
Copy link
Collaborator Author

mbstadler commented Jun 24, 2019

I have made an R implementation of the motif comparison used in compareMotifs.pl. It calculated the all-pairs similarity matrix for a set of 579 vertebrate factors in JASPAR2018 in less than 4 minutes (pure R implementation, single CPU). Results are identical.

I have added naive parallelization using mclapply as well, which brings this down to ~25s on 30 cores.

Is it worth considering that instead of compareMotifs.pl?

@mbstadler
Copy link
Collaborator Author

The function has been renamed motifSimilarity

@mbstadler mbstadler changed the title clusterPWMs features motifSimilarity (former clusterPWMs) features Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant