Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log-odds score cutoff when dumping PWMs to a file #2

Open
mbstadler opened this issue Apr 21, 2018 · 1 comment
Open

log-odds score cutoff when dumping PWMs to a file #2

mbstadler opened this issue Apr 21, 2018 · 1 comment

Comments

@mbstadler
Copy link
Collaborator

mbstadler commented Apr 21, 2018

A PWM match-score cutoff is mandatory when dumping PWMs into a file in Homer format.

Currently, the score cutoff is constant (log(2^10)) and identical for all PWMs.

Maybe the function should accept an argument to allow to choose between a constant cutoff (current behaviour), or a cut-off that is min(constant, PWMmaxScore), or a relative cut-off (e.g. 80% of PWMmaxScore).

@mbstadler
Copy link
Collaborator Author

In addition, the conversion between PWMList and homerfile should be implemented in such a way that motif names will be consistent (same SE rownames returned by calcBinnedMotifEnr() for method = "R" and method = "Homer".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant