Merge pull request yajra#2222 from yajra/fix-skip

yajra · web-flow · commit 7ca195825d69 · 2019-10-24T11:47:24.000+08:00
[9.0] Fix skipTotalRecords api not working on initial state.
diff --git a/src/QueryDataTable.php b/src/QueryDataTable.php
@@ -158,7 +158,9 @@ public function keepSelectBindings()
     public function totalCount()
     {
         if ($this->skipTotalRecords) {
-            return true;
+            $this->isFilterApplied = true;
+
+            return 1;
         }
 
         return $this->totalRecords ? $this->totalRecords : $this->count();

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,9 @@ public function keepSelectBindings()`
`158`	`158`	`public function totalCount()`
`159`	`159`	`{`
`160`	`160`	`if ($this->skipTotalRecords) {`
`161`		`- return true;`
	`161`	`+ $this->isFilterApplied = true;`
	`162`	`+`
	`163`	`+ return 1;`
`162`	`164`	`}`
`163`	`165`
`164`	`166`	`return $this->totalRecords ? $this->totalRecords : $this->count();`