Skip to content

Commit be0e533

Browse files
authored
feat: differentiate between cache disabled and cache put failure (#719)
fix: add icon for put failure Signed-off-by: James <[email protected]>
1 parent ffb161c commit be0e533

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

packages/console/src/components/Executions/CacheStatus.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { makeStyles, Theme } from '@material-ui/core/styles';
33
import CachedOutlined from '@material-ui/icons/CachedOutlined';
44
import ErrorOutlined from '@material-ui/icons/ErrorOutlined';
55
import InfoOutlined from '@material-ui/icons/InfoOutlined';
6+
import SmsFailedOutlinedIcon from '@material-ui/icons/SmsFailedOutlined';
67
import classnames from 'classnames';
78
import { assertNever } from 'common/utils';
89
import { PublishedWithChangesOutlined } from 'components/common/PublishedWithChanges';
@@ -37,10 +38,14 @@ const NodeExecutionCacheStatusIcon: React.ComponentType<
3738
}
3839
> = React.forwardRef(({ status, ...props }, ref) => {
3940
switch (status) {
40-
case CatalogCacheStatus.CACHE_DISABLED:
41+
case CatalogCacheStatus.CACHE_DISABLED: {
42+
return <InfoOutlined {...props} ref={ref} data-testid="cache-icon" />;
43+
}
4144
case CatalogCacheStatus.CACHE_MISS:
4245
case CatalogCacheStatus.CACHE_SKIPPED: {
43-
return <InfoOutlined {...props} ref={ref} data-testid="cache-icon" />;
46+
return (
47+
<SmsFailedOutlinedIcon {...props} ref={ref} data-testid="cache-icon" />
48+
);
4449
}
4550
case CatalogCacheStatus.CACHE_HIT: {
4651
return <CachedOutlined {...props} ref={ref} data-testid="cache-icon" />;

0 commit comments

Comments
 (0)