Skip to content
This repository was archived by the owner on Apr 30, 2020. It is now read-only.

Allow composer installations for features #84

Open
bdbch opened this issue Aug 29, 2018 · 2 comments
Open

Allow composer installations for features #84

bdbch opened this issue Aug 29, 2018 · 2 comments

Comments

@bdbch
Copy link
Contributor

bdbch commented Aug 29, 2018

Since Flynt already uses Composer to install Wordpress Plugins it would be cool, if we could also use composer to install Flynt features. I developed a small feature and published it to Github but the installation process is quite annoying with manual copying or git submodules.

Is this possible?

@domtra
Copy link
Member

domtra commented Aug 29, 2018

Quickly thinking about it, I am wondering if you can just achieve want you want to with composer installer-paths. https://getcomposer.org/doc/faqs/how-do-i-install-a-package-to-a-custom-path-for-my-framework.md
You need to require it in your package and can sepecify the location in the projects composer.json.
Maybe you can give that a try. Let me know if you need any assistance.

@bdbch
Copy link
Contributor Author

bdbch commented Aug 29, 2018

That would be exactly what it takes to handle Features via Composer. I just wondered about

  1. How will these Features be handled via gitignore? Since I don't really want to make accidental changes to a composer installed Feature there would be a need to somehow ignore them specifically.

  2. What Package Type should the Features use? Here is a list of available package types. Custom package types are not allowed as stated here. I already created a ticket if there could be an addition for a flynt-feature package type but since Flynt is such a "young" framework I doubt them adding it to the list. Something that could work is the solution they stated in their "Should we allow dynamic package types or paths" section: https://github.com/oomphinc/composer-installers-extender

Otherwise the Composer Installer Path solution would be perfect.

(Also sorry if this is not the right project. I was unsure where I should add this issue.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants