Merge pull request #11 from jcs-PR/fix

Ready for resubmission

Author: cpitclaudel

README.md

@@ -1,18 +1,20 @@
 # flycheck-google-cpplint.el
 
+[![License: GPL v3](https://img.shields.io/badge/License-GPL%20v3-green.svg)](https://www.gnu.org/licenses/gpl-3.0)
+
 Add Google C++ Style checker for [Flycheck](https://github.com/flycheck/flycheck).
 
 If you're want to write code according to the
-[Google C++ Style Guide](http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml)
+[Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html)
 , this will help a great deal.
 
 I recommend that the package
-[google-c-style](http://melpa.milkbox.net/#/google-c-style)
+[google-c-style](https://melpa.org/#/google-c-style)
 also installed with.
 
 ## Installation
 
-As usual, from [MELPA](http://melpa.milkbox.net).
+As usual, from [MELPA](https://melpa.org/#/).
 
 In your [Cask](http://cask.github.io) file:
 
@@ -25,7 +27,7 @@ In your [Cask](http://cask.github.io) file:
 
 In your `init.el`:
 
-```
+```el
 (eval-after-load 'flycheck
   '(progn
      (require 'flycheck-google-cpplint)
@@ -37,38 +39,24 @@ In your `init.el`:
 
 If you not use `cppcheck`. You have need to change `flycheck-add-next-checker`.
 
-```
+```el
 (flycheck-add-next-checker 'c/c++-clang
                            '(warning . c/c++-googlelint))
 ```
 
 ## Usage
 
-### Install cpplint.py
-
-```
-$ wget http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py
-$ sudo mv cpplint.py /usr/local/bin/cpplint.py
-$ sudo chmod 755 /usr/local/bin/cpplint.py
-```
-
-You should be able to run the `cpplint.py` command in Emacs.
-If above location,
+### Install `cpplint` through `pip`
 
 ```
-(executable-find "cpplint.py") ; => "/usr/local/bin/cpplint.py"
+$ pip install cpplint
 ```
 
-or
-
-```
-(custom-set-variables
- '(flycheck-c/c++-googlelint-executable "/usr/local/bin/cpplint.py"))
-```
+*P.S. Make sure cpplint is in your environment path settings*
 
 ### Configure for cpplint.py
 
-```
+```el
 (custom-set-variables
  '(flycheck-googlelint-verbose "3")
  '(flycheck-googlelint-filter "-whitespace,+whitespace/braces")
@@ -88,7 +76,7 @@ WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A
 PARTICULAR PURPOSE.  See the GNU General Public License for more details.
 
 You should have received a copy of the GNU General Public License along with
-this program.  If not, see http://www.gnu.org/licenses/.
+this program.  If not, see https://www.gnu.org/licenses/.
 
 See
 [COPYING](https://github.com/flycheck/flycheck-google-cpplint/blob/master/COPYING)

flycheck-google-cpplint.el

@@ -3,6 +3,7 @@
 ;; Copyright (C) 2014  Akiha Senda
 
 ;; Author: Akiha Senda <[email protected]>
+;; Maintainer: Jen-Chieh Shen <[email protected]>
 ;; URL: https://github.com/flycheck/flycheck-google-cpplint/
 ;; Version: 1.0.1
 ;; Keywords: flycheck, C, C++
@@ -21,21 +22,21 @@
 ;; GNU General Public License for more details.
 
 ;; You should have received a copy of the GNU General Public License
-;; along with this program.  If not, see <http://www.gnu.org/licenses/>.
+;; along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 ;;; Commentary:
 
 ;; This is extension for Flycheck.
 
 ;; If you're want to write code according to the Google C++ Style Guide,
 ;; this will help a great deal.
-;; http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml
+;; https://google.github.io/styleguide/cppguide.html
 
 ;; I recommend that the package google-c-style also installed with.
-;; http://melpa.milkbox.net/#/google-c-style
+;; https://melpa.org/#/google-c-style
 
 ;; For more infomations, please check the GitHub
-;; https://github.com/senda-akiha/flycheck-google-cpplint/
+;; https://github.com/flycheck/flycheck-google-cpplint/
 
 ;;;; Setup
 
@@ -120,8 +121,9 @@ linelength=digits
   "A C/C++ style checker using google cpplint.
 
 See URL
-`http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py'."
-  :command ("cpplint.py"
+`https://github.com/google/styleguide/blob/gh-pages/cpplint/cpplint.py' and
+`https://pypi.org/project/cpplint/#description'."
+  :command ("cpplint"
             (option "--verbose=" flycheck-googlelint-verbose concat)
             (option "--filter=" flycheck-googlelint-filter concat
                     flycheck-option-comma-separated-list)
@@ -135,5 +137,4 @@ See URL
 (add-to-list 'flycheck-checkers 'c/c++-googlelint 'append)
 
 (provide 'flycheck-google-cpplint)
-
 ;;; flycheck-google-cpplint.el ends here