Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push configuration should support spec discovery/inference from GitRepository.spec.ref.name #876

Open
iAnomaly opened this issue Mar 27, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@iAnomaly
Copy link

Currently, ImageUpdateAutomation push configuration only supports discovery/inference of a sourceRef.kind: GitRepository from GitRepository.spec.ref.branch. See code here: https://github.com/fluxcd/image-automation-controller/blob/main/internal/source/git.go#L158-L161

Support should be expanded to handle GitRepository.spec.ref.name such as refs/heads/main. This is especially critical for flux-operator users as the FluxInstance sync configuration via spec.sync.ref produces a GitRepository with .spec.ref.name rather than .spec.ref.branch. As such, any flux-operator user with imageupdateautomations must explicitly set spec.git.checkout.ref instead of relying on the convenience of automatic discovery/inference.

@stefanprodan stefanprodan added the enhancement New feature or request label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants