Skip to content

Commit 22bcb9d

Browse files
author
Jonah Williams
authored
[framework] re-enable skipped impeller goldens. (flutter#166354)
Fixes flutter#143616 Maybe. Lets see if its stable. Update: I've run this a few times and it seems stable.
1 parent 3fa9b38 commit 22bcb9d

File tree

4 files changed

+6
-13
lines changed

4 files changed

+6
-13
lines changed

packages/flutter/test/cupertino/date_picker_test.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ import 'package:flutter/material.dart';
1717
import 'package:flutter/rendering.dart';
1818
import 'package:flutter_test/flutter_test.dart';
1919

20-
import '../impeller_test_helpers.dart';
21-
2220
// TODO(yjbanov): on the web text rendered with perspective produces flaky goldens: https://github.com/flutter/flutter/issues/110785
2321
final bool skipPerspectiveTextGoldens = isBrowser && isSkwasm;
2422

@@ -1611,7 +1609,7 @@ void main() {
16111609
matchesGoldenFile('date_picker_test.datetime.drag.png'),
16121610
);
16131611
}
1614-
}, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/143616
1612+
});
16151613

16161614
testWidgets('DatePicker displays the date in correct order', (WidgetTester tester) async {
16171615
await tester.pumpWidget(
@@ -1761,7 +1759,7 @@ void main() {
17611759
matchesGoldenFile('timer_picker_test.datetime.drag.png'),
17621760
);
17631761
}
1764-
}, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/143616
1762+
});
17651763

17661764
testWidgets('TimerPicker only changes hour label after scrolling stops', (
17671765
WidgetTester tester,

packages/flutter/test/widgets/color_filter_test.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ import 'package:flutter/material.dart';
1212
import 'package:flutter/rendering.dart';
1313
import 'package:flutter_test/flutter_test.dart';
1414

15-
import '../impeller_test_helpers.dart';
16-
1715
void main() {
1816
testWidgets('Color filter - red', (WidgetTester tester) async {
1917
await tester.pumpWidget(
@@ -56,7 +54,7 @@ void main() {
5654
),
5755
);
5856
await expectLater(find.byType(ColorFiltered), matchesGoldenFile('color_filter_sepia.png'));
59-
}, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/143616
57+
});
6058

6159
testWidgets('Color filter - reuses its layer', (WidgetTester tester) async {
6260
Future<void> pumpWithColor(Color color) async {

packages/flutter/test/widgets/selectable_text_test.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import 'package:flutter/services.dart';
2020
import 'package:flutter_test/flutter_test.dart';
2121
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
2222

23-
import '../impeller_test_helpers.dart';
2423
import '../widgets/clipboard_utils.dart';
2524
import '../widgets/editable_text_utils.dart' show textOffsetToPosition;
2625
import '../widgets/semantics_tester.dart';
@@ -5267,7 +5266,7 @@ void main() {
52675266
find.byType(MaterialApp),
52685267
matchesGoldenFile('selectable_text_golden.TextSelectionStyle.1.png'),
52695268
);
5270-
}, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/143616
5269+
});
52715270

52725271
testWidgets('text selection style 2', (WidgetTester tester) async {
52735272
await tester.pumpWidget(
@@ -5304,7 +5303,7 @@ void main() {
53045303
find.byType(MaterialApp),
53055304
matchesGoldenFile('selectable_text_golden.TextSelectionStyle.2.png'),
53065305
);
5307-
}, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/143616
5306+
});
53085307

53095308
testWidgets('keeps alive when has focus', (WidgetTester tester) async {
53105309
await tester.pumpWidget(

packages/flutter/test/widgets/shader_mask_test.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ library;
1010
import 'package:flutter/widgets.dart';
1111
import 'package:flutter_test/flutter_test.dart';
1212

13-
import '../impeller_test_helpers.dart';
14-
1513
Shader createShader(Rect bounds) {
1614
return const LinearGradient(
1715
begin: Alignment.topCenter,
@@ -102,5 +100,5 @@ void main() {
102100
find.byType(RepaintBoundary),
103101
matchesGoldenFile('shader_mask.bounds.matches_top_left.png'),
104102
);
105-
}, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/144555
103+
});
106104
}

0 commit comments

Comments
 (0)