Additional improvements around the UX of invoking profile runs

[gspencergoog]

Steps to Reproduce

I loaded up an app, and looked at the toolbar, trying to find something I could click to run a profile build:

Note that (for some reason) the "profile" toolbar button is disabled and the "Profile main.dart" menu item is disabled, but "Profile..." and "Flutter run 'main.dart' in Profile Mode" are enabled. Can I profile this or not? :)

Also, when I select the "Profile..." menu item, I get the little persistent popup menu which includes "Run", but when I click that, it does a debug run, not a profile run.

My suspicion is that multiple plugins are fighting here over the term "Profile" (Dart and Flutter?), and that the "Run" is overloaded to run Flutter, but it's super confusing for the user. Is there any way that:

1. A Flutter app can "win" this fight and put an enabled profile button on the toolbar, replacing the existing disabled one?
2. Or, At least add one that is enabled (and runs "flutter run" in profile mode) so that I have something up there by default?

Version info

[✓] Flutter (Channel chip_perf, v0.3.6-pre.30, on Mac OS X 10.13.3 17D102, locale en-US)
    • Flutter version 0.3.6-pre.30 at /Users/gspencer/code/flutter
    • Framework revision 5beb182ad1 (9 hours ago), 2018-05-01 08:22:29 -0700
    • Engine revision 613aae032f
    • Dart version 2.0.0-dev.50.0.flutter-cd0c4e4fe1

[✓] Android toolchain - develop for Android devices (Android SDK 26.0.2)
    • Android SDK at /Users/gspencer/Library/Android/sdk
    • Android NDK at /Users/gspencer/Library/Android/sdk/ndk-bundle
    • Platform android-27, build-tools 26.0.2
    • ANDROID_HOME = /Users/gspencer/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b08)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 9.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 9.2, Build version 9C40b
    • ios-deploy 1.9.2
    • CocoaPods version 1.4.0

[✓] Android Studio (version 3.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    • Dart plugin version 162.2924
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b08)

[✓] IntelliJ IDEA Community Edition (version 2018.1.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 23.2.3
    • Dart plugin version 181.4445.29

[✓] Connected devices (1 available)
    • Pixel 2 • FA81A1A02109 • android-arm64 • Android 8.1.0 (API 27)

• No issues found!

[devoncarew]

Note that (for some reason) the "profile" toolbar button is disabled

This seems like one of the bigger issues above - we'd like launch config button and the Flutter run 'main.dart' in Profile Mode menu item to be the main entry points for profiling.

I see Android Studio and IntelliJ IDEA listed in your doctor output; which one where you running the above in? Is it up to date? Any indication about why the launch config button wasn't enabled?

[gspencergoog]

It was IntelliJ, and yes, it's up to date. No indication about why it wasn't enabled.

[devoncarew]

Was this for an existing project or a relatively now one? I'm wondering if there's project metadata that's not up to date. I see the profile launch config button enabled for new projects locally:

Do you mind creating a new project and seeing if it's enabled for you? Thanks!

[gspencergoog]

A relatively new one, but I created a new one just now and tried it, with the same result.

I'm using the HEAD of the master repo for Flutter, so I suppose something could be out of sync there.

[gspencergoog]

Aha! OK, so I guess I lied: I thought I had the latest (I always upgrade as soon as it tells me one is available, but I guess I missed one) I had 2018.1.1, and the latest is 2018.1.2, and after updating to that, the icon is enabled.

There's still some confusion in my mind about the difference between that profile button, the "Flutter run main.dart in profile mode" menu selection, and the "Profile..." persistent popup, but as long as it works to click that icon, it's a lot better.

[devoncarew]

I definitely agree there's room for some additional cleanup here.

I wasn't aware that you could essentially tear off the Profile... menu item, so we're probably not handling something there correctly.

Good to know that updating fixed the issue w/ the launch button; I am a bit surprised that it was as small a delta as 2018.1.1 ==> 2018.1.2.

[gspencergoog]

Here's another case where the button is disabled:

1. I click the "profile" icon (which was enabled, yay!)
2. I run the app, make a code change, and the hit save (command-s)
3. Notice that the app thinks it should hot reload, even though it can't, and that the profile button is now disabled....

[devoncarew]

oops! Thanks for letting us know.