Skip to content

Commit 46428da

Browse files
committed
remove RTCConfiguration convert.
1 parent b78d7c7 commit 46428da

File tree

5 files changed

+7
-29
lines changed

5 files changed

+7
-29
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Changelog
22

33
--------------------------------------------
4+
[1.4.1] - 2024-04-12
5+
6+
* remove RTCConfiguration convert.
7+
48
[1.4.0] - 2024-04-09
59

610
* Fixed bug for RTCConfiguration convert.

lib/src/factory_impl.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class RTCFactoryWeb extends RTCFactory {
4242
],
4343
};
4444
final jsRtcPc = web.RTCPeerConnection(
45-
convertRTCConfiguration({...constr, ...configuration}));
45+
{...constr, ...configuration} as web.RTCConfiguration);
4646
final _peerConnectionId = base64Encode(jsRtcPc.toString().codeUnits);
4747
return RTCPeerConnectionWeb(_peerConnectionId, jsRtcPc);
4848
}

lib/src/rtc_peerconnection_impl.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import 'rtc_dtmf_sender_impl.dart';
1515
import 'rtc_rtp_receiver_impl.dart';
1616
import 'rtc_rtp_sender_impl.dart';
1717
import 'rtc_rtp_transceiver_impl.dart';
18-
import 'utils.dart';
1918

2019
extension on web.RTCDataChannelInit {
2120
external set binaryType(String value);
@@ -264,7 +263,7 @@ class RTCPeerConnectionWeb extends RTCPeerConnection {
264263
@override
265264
Future<void> setConfiguration(Map<String, dynamic> configuration) {
266265
_configuration.addAll(configuration);
267-
_jsPc.setConfiguration(convertRTCConfiguration(configuration));
266+
_jsPc.setConfiguration(configuration as web.RTCConfiguration);
268267
return Future.value();
269268
}
270269

lib/src/utils.dart

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -27,28 +27,3 @@ String randomString(int length) {
2727
}
2828
return buf.toString();
2929
}
30-
31-
web.RTCConfiguration convertRTCConfiguration(
32-
Map<String, dynamic> configuration) {
33-
final object = jsutil.newObject();
34-
for (var key in configuration.keys) {
35-
if (key == 'iceServers') {
36-
final servers = configuration[key] as List<dynamic>;
37-
final jsServers = <web.RTCIceServer>[];
38-
for (var server in servers) {
39-
var iceServer = web.RTCIceServer(urls: server['urls']);
40-
if (server['username'] != null) {
41-
iceServer.username = server['username'];
42-
}
43-
if (server['credential'] != null) {
44-
iceServer.credential = server['credential'];
45-
}
46-
jsServers.add(iceServer);
47-
}
48-
jsutil.setProperty(object, key, jsServers);
49-
} else {
50-
jsutil.setProperty(object, key, configuration[key]);
51-
}
52-
}
53-
return object as web.RTCConfiguration;
54-
}

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: dart_webrtc
22
description: Use the dart/js library to re-wrap the webrtc js interface of the browser, to adapted common browsers.
3-
version: 1.4.0
3+
version: 1.4.1
44
homepage: https://github.com/flutter-webrtc/dart-webrtc
55

66
environment:

0 commit comments

Comments
 (0)