Skip to content

Cookie Policy Popup display when is not enable #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
przemyslawdziadek opened this issue Oct 2, 2019 · 0 comments
Open

Cookie Policy Popup display when is not enable #6

przemyslawdziadek opened this issue Oct 2, 2019 · 0 comments

Comments

@przemyslawdziadek
Copy link

Hi. I find a bug in Block/Customer/PrivacyPopup.php file.

the function

protected function _toHtml()
{
        if (
            !$this->privacyHelper->isModuleEnabled() &&
            !$this->privacyHelper->isPopupNotificationEnabled()
        ) {
            return '';
        }
        return parent::_toHtml();
}

I think it should look like this:

protected function _toHtml()
{
        if (
            !$this->privacyHelper->isModuleEnabled() ||
            !$this->privacyHelper->isPopupNotificationEnabled()
        ) {
            return '';
        }
        return parent::_toHtml();
}

because when if clausule looks like this !$this->privacyHelper->isModuleEnabled() && !$this->privacyHelper->isPopupNotificationEnabled() then popup display when is not enable in settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant