Skip to content

Commit f2deab3

Browse files
committed
Auto merge of rust-lang#13232 - Alexendoo:path-prefix, r=flip1995
Add path prefixes back when compiling `clippy_dev` and `lintcheck` `cargo dev` and `cargo lintcheck` use `--manifest-path` to select the package to compile, with this Cargo changes the CWD to the package's containing directory meaning paths in diagnostics start from e.g. `src/` instead of `clippy_dev/src/` Lintcheck uses a `--remap-path-prefix` trick when linting crates to re-add the directory name in diagnostics: https://github.com/rust-lang/rust-clippy/blob/5ead90f13ae3e03f0c346aea3198f18298960d83/lintcheck/src/main.rs#L93-L94 https://github.com/rust-lang/rust-clippy/blob/5ead90f13ae3e03f0c346aea3198f18298960d83/lintcheck/src/main.rs#L102-L103 It works well as far as I can tell, when absolute paths appear they stay absolute and do not have the prefix added [`profile-rustflags`](https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#profile-rustflags-option) allows us to set per package `RUSTFLAGS` in order to use the same trick on the `clippy_dev` and `lintcheck` packages themselves Now when you run into warnings/errors the filename will be correctly clickable Before ``` error[E0425]: cannot find value `moo` in this scope --> src/lib.rs:41:5 | 41 | moo; | ^^^ not found in this scope ``` After ``` error[E0425]: cannot find value `moo` in this scope --> clippy_dev/src/lib.rs:41:5 | 41 | moo; | ^^^ not found in this scope ``` r? `@flip1995` changelog: none
2 parents 5ead90f + 8225f2a commit f2deab3

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

.cargo/config.toml

+7
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,13 @@ target-dir = "target"
1313

1414
[unstable]
1515
binary-dep-depinfo = true
16+
profile-rustflags = true
1617

1718
[profile.dev]
1819
split-debuginfo = "unpacked"
20+
21+
# Add back the containing directory of the packages we have to refer to using --manifest-path
22+
[profile.dev.package.clippy_dev]
23+
rustflags = ["--remap-path-prefix", "=clippy_dev"]
24+
[profile.dev.package.lintcheck]
25+
rustflags = ["--remap-path-prefix", "=lintcheck"]

0 commit comments

Comments
 (0)