Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor context menu operations #38

Open
flekschas opened this issue Oct 30, 2019 · 0 comments
Open

Refactor context menu operations #38

flekschas opened this issue Oct 30, 2019 · 0 comments
Labels
improvement A feature improvement

Comments

@flekschas
Copy link
Owner

The context menu operations are currently implemented in a pretty procedural fashion. I.e., instead of a function called hideContextMenu() there are several duplicated calls to query for the menu's dom element and hiding it directly via element.style.display = 'none'.
@flekschas flekschas added the improvement A feature improvement label Oct 30, 2019
eeeeenchanted added a commit that referenced this issue Nov 7, 2019
@eeeeenchanted
fixed issue #38
98ea9ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement A feature improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flekschas