From 7b0cc5622866acb174434fcffc98137392986764 Mon Sep 17 00:00:00 2001 From: Sebastian Wick Date: Fri, 19 Jan 2024 17:28:16 +0100 Subject: [PATCH] Update FIXMEs --- src/xdp-utils.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/xdp-utils.h b/src/xdp-utils.h index 835b60480..035f0d0a4 100644 --- a/src/xdp-utils.h +++ b/src/xdp-utils.h @@ -82,10 +82,9 @@ char * xdp_app_info_get_instance (XdpAppInfo *app_info); gboolean xdp_app_info_is_host (XdpAppInfo *app_info); gboolean xdp_app_info_is_flatpak (XdpAppInfo *app_info); XdpAppInfoKind xdp_app_info_get_kind (XdpAppInfo *app_info); -// FIXME Should fallback to current impls. Containers1 metadata could be used here. +// FIXME Does remapping based on flatpak metadata. We might be able to use Containers1 metadata but this could be tricky. char * xdp_app_info_remap_path (XdpAppInfo *app_info, const char *path); -// FIXME PID/TID mapping: what we want is dbus->pidfd->pidns, but can't because pidfd is from proxy. Use flatpak/bwrap specific path for now. gboolean xdp_app_info_map_pids (XdpAppInfo *app_info, pid_t *pids, guint n_pids, @@ -112,7 +111,7 @@ GAppInfo * xdp_app_info_load_app_info (XdpAppInfo *app_info); char ** xdp_app_info_rewrite_commandline (XdpAppInfo *app_info, const char *const *commandline, gboolean quote_escape); -// FIXME TODO +// FIXME Needs investigation. Not even sure what it does. char *xdp_app_info_get_tryexec_path (XdpAppInfo *app_info); G_DEFINE_AUTOPTR_CLEANUP_FUNC(XdpAppInfo, xdp_app_info_unref)