Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow downstream filtering on transaction booleans in model netsuite2__transaction_details #113

Closed
2 of 4 tasks
FrankTub opened this issue Mar 26, 2024 · 7 comments · Fixed by #117
Closed
2 of 4 tasks
Assignees
Labels
priority:p4 Affects few users; pick up when available status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates

Comments

@FrankTub
Copy link

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

I would like to use model netsuite2__transaction_details in downstream models that I create in my own project. To do it in an efficient way I would like to be able to filter on at least the following columns.

  • is_main_line
  • is_tax_line
  • is_closed

Describe alternatives you've considered

Misuse transaction_lines_pass_through_columns and create your own column that is passed through.

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-reneeli
Copy link
Contributor

Hi @FrankTub thanks for opening this and highlighting your use case, in addition to opening that PR!

We've added this to our backlog and will pick this up when our team has availability.

@fivetran-reneeli fivetran-reneeli added the type:enhancement New functionality or enhancement label Mar 27, 2024
@FrankTub
Copy link
Author

FrankTub commented Apr 4, 2024

@fivetran-reneeli , do you have an indication on how long such a PR will take? If it takes some more time I will have to change my code setup and figure out another solution so we can meet business deadlines at our side.

@fivetran-catfritz
Copy link
Contributor

Hi @FrankTub I have started working on performance updates to our Netsuite package and will fold your PR into mine. These updates will most likely be released by the end of this month.

In the meantime you should be able to point your packages.yml to the branch that you shared in your PR, since we do not plan to release any updates between now and my next update. Let me know if you have any questions about this!

@FrankTub
Copy link
Author

FrankTub commented Apr 5, 2024

Thanks for the update @fivetran-catfritz , that will work for us.

@FrankTub
Copy link
Author

FrankTub commented Apr 5, 2024

Have added some additional fields since I want to use the model netsuite2__transaction_details for all sorts of downstream models and need some additional keys to do so that cannot simply be placed in your dbt project as pass through fields.

@fivetran-catfritz fivetran-catfritz self-assigned this Apr 11, 2024
@fivetran-catfritz fivetran-catfritz added priority:p4 Affects few users; pick up when available status:in_progress Currently being worked on update_type:models Primary focus requires model updates labels Apr 11, 2024
@fivetran-catfritz
Copy link
Contributor

@FrankTub To update you, I am planning to merge you branch into our next release branch tomorrow. I will also push some small documentation updates to your branch before I do.

@fivetran-catfritz
Copy link
Contributor

@FrankTub I have merged your changes into our next release branch to be batch released with our other updates in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p4 Affects few users; pick up when available status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants