-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Allow downstream filtering on transaction booleans in model netsuite2__transaction_details #113
Comments
Hi @FrankTub thanks for opening this and highlighting your use case, in addition to opening that PR! We've added this to our backlog and will pick this up when our team has availability. |
@fivetran-reneeli , do you have an indication on how long such a PR will take? If it takes some more time I will have to change my code setup and figure out another solution so we can meet business deadlines at our side. |
Hi @FrankTub I have started working on performance updates to our Netsuite package and will fold your PR into mine. These updates will most likely be released by the end of this month. In the meantime you should be able to point your packages.yml to the branch that you shared in your PR, since we do not plan to release any updates between now and my next update. Let me know if you have any questions about this! |
Thanks for the update @fivetran-catfritz , that will work for us. |
Have added some additional fields since I want to use the model |
@FrankTub To update you, I am planning to merge you branch into our next release branch tomorrow. I will also push some small documentation updates to your branch before I do. |
@FrankTub I have merged your changes into our next release branch to be batch released with our other updates in the coming weeks. |
Is there an existing feature request for this?
Describe the Feature
I would like to use model
netsuite2__transaction_details
in downstream models that I create in my own project. To do it in an efficient way I would like to be able to filter on at least the following columns.is_main_line
is_tax_line
is_closed
Describe alternatives you've considered
Misuse
transaction_lines_pass_through_columns
and create your own column that is passed through.Are you interested in contributing this feature?
Anything else?
No response
The text was updated successfully, but these errors were encountered: