RTC-520 Add new notifications PeerAdded and PeerDeleted (#64)

* Add tests for new notifications

* Update protos

* Fix timeout in PeerDeleted notification

Author: Rados13

lib/jellyfish/notification.ex

@@ -37,6 +37,30 @@ defmodule Jellyfish.Notification do
           }
   end
 
+  defmodule PeerAdded do
+    @moduledoc nil
+
+    @enforce_keys [:room_id, :peer_id]
+    defstruct @enforce_keys
+
+    @type t :: %__MODULE__{
+            room_id: Room.id(),
+            peer_id: Peer.id()
+          }
+  end
+
+  defmodule PeerDeleted do
+    @moduledoc nil
+
+    @enforce_keys [:room_id, :peer_id]
+    defstruct @enforce_keys
+
+    @type t :: %__MODULE__{
+            room_id: Room.id(),
+            peer_id: Peer.id()
+          }
+  end
+
   defmodule PeerConnected do
     @moduledoc nil
 

lib/protos/jellyfish/server_notifications.pb.ex

@@ -26,6 +26,24 @@ defmodule Jellyfish.ServerMessage.RoomCrashed do
   field :room_id, 1, type: :string, json_name: "roomId"
 end
 
+defmodule Jellyfish.ServerMessage.PeerAdded do
+  @moduledoc false
+
+  use Protobuf, syntax: :proto3, protoc_gen_elixir_version: "0.12.0"
+
+  field :room_id, 1, type: :string, json_name: "roomId"
+  field :peer_id, 2, type: :string, json_name: "peerId"
+end
+
+defmodule Jellyfish.ServerMessage.PeerDeleted do
+  @moduledoc false
+
+  use Protobuf, syntax: :proto3, protoc_gen_elixir_version: "0.12.0"
+
+  field :room_id, 1, type: :string, json_name: "roomId"
+  field :peer_id, 2, type: :string, json_name: "peerId"
+end
+
 defmodule Jellyfish.ServerMessage.PeerConnected do
   @moduledoc false
 
@@ -305,4 +323,11 @@ defmodule Jellyfish.ServerMessage do
     type: Jellyfish.ServerMessage.TrackMetadataUpdated,
     json_name: "trackMetadataUpdated",
     oneof: 0
+
+  field :peer_added, 20, type: Jellyfish.ServerMessage.PeerAdded, json_name: "peerAdded", oneof: 0
+
+  field :peer_deleted, 21,
+    type: Jellyfish.ServerMessage.PeerDeleted,
+    json_name: "peerDeleted",
+    oneof: 0
 end

protos

@@ -10,7 +10,9 @@ defmodule Jellyfish.NotifierTest do
   alias Jellyfish.Notification.{
     ComponentTrackAdded,
     ComponentTrackRemoved,
+    PeerAdded,
     PeerConnected,
+    PeerDeleted,
     PeerDisconnected,
     PeerMetadataUpdated,
     RoomCreated,
@@ -157,6 +159,11 @@ defmodule Jellyfish.NotifierTest do
       {:ok, %{peer: %Jellyfish.Peer{id: peer_id}, token: peer_token}} =
         Room.add_peer(client, room_id, @peer_opts)
 
+      assert_receive {:jellyfish, %PeerAdded{peer_id: ^peer_id, room_id: ^room_id} = peer_added},
+                     1_000
+
+      assert_receive {:webhook, ^peer_added}, 2_500
+
       {:ok, peer_ws} = WS.start_link("ws://#{jellyfish_address}/socket/peer/websocket")
 
       auth_request = %PeerMessage{content: {:auth_request, %AuthRequest{token: peer_token}}}
@@ -176,6 +183,12 @@ defmodule Jellyfish.NotifierTest do
 
       assert_receive {:webhook, ^peer_disconnected}, 2_500
 
+      assert_receive {:jellyfish,
+                      %PeerDeleted{peer_id: ^peer_id, room_id: ^room_id} = peer_deleted},
+                     2_500
+
+      assert_receive {:webhook, ^peer_deleted}, 2_500
+
       assert_receive {:jellyfish, %RoomDeleted{room_id: ^room_id} = room_deleted},
                      2_500
 
@@ -249,6 +262,11 @@ defmodule Jellyfish.NotifierTest do
     {:ok, %{peer: %Jellyfish.Peer{id: peer_id}, token: peer_token, ws_url: peer_ws_url}} =
       Room.add_peer(client, room_id, @peer_opts)
 
+    assert_receive {:jellyfish, %PeerAdded{peer_id: ^peer_id, room_id: ^room_id} = peer_added},
+                   1_000
+
+    assert_receive {:webhook, ^peer_added}, 2_500
+
     {:ok, peer_ws} = WS.start_link("ws://#{peer_ws_url}")
 
     auth_request = %PeerMessage{content: {:auth_request, %AuthRequest{token: peer_token}}}