New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect <link rel="canonical" ...> in documentation #31

Open

maxnikulin opened this issue Sep 28, 2023 · 0 comments

maxnikulin commented Sep 28, 2023

HTML markup on documentation pages contains incorrect <link rel="canonical" ...> elements:

curl -s  'https://firewalld.org/documentation/' | grep 'link rel="canonical"'
  <link rel="canonical" href="/documentation/">
<link rel="canonical" href="firewalld.github.io/documentation/" />

There should be just one canonical link.
Second link is treated as relative to https://firewalld.org/documentation/, so https://firewalld.org/documentation/firewalld.github.io/documentation/ is certainly an error. Likely, having a dedicated domain, you do not want to consider github.io is the primary location.

Perhaps the theme used to generate documentation should be fixed to avoid github.io links.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment