-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug when clicking on cancel with version 1.6.3 #99
Comments
After a few days of use on production, the statistics of the users having a crash increased to more than 2% (only iOS). |
@firescript Further info: Doing a rollback didn't help (App is always crashing for 2% if my user on prod) so I think that this bug is caused by Nativescript 8 (while moving to nativescript-contacts 1.6.3 I also upgraded to Nativescript 8). Maybe it's worth looking at this PR: #97 |
We could merge that, and bump npm again. Would that solve your issue? |
I didn't check the content/quality of this PR, but if the migration was correctly done, then yes if would really help! |
@firescript Any news on this? Would it be possible to merge the PR in a branch and publish a beta version? I can then do some tests to check if is solves the problem. |
Now that the pull request 97 is merged , waiting for the next release. |
@firescript Yes it would be good if you could release a new version at least a beta so that I can make some tests... |
After updating to version 1.6.3 and releasing on prod, I can confirm that the bug #75 is now fixed! Thanks again @dlcole @firescript
Unfortunately, I also noticed that a new issue raised up. Looking at the statistics it seems that 1-2% of the users have an issue that makes the application crash. Actually it's quite simple to reproduce, you have to open the contact plugin and click on cancel to close it. Usually it's working, but sometime it's not. I was able to reproduce it on some phone and some other not.
On average, I would say that I have to open/close the contact plugin more or less 5 times before the application crashes (sometimes it crashes after the first time, sometimes you have to try 20 times and as said, on some devices, its never crashing...)
Any idea what the problem could be? In my opinion, it's new with the version 1.6.3
The text was updated successfully, but these errors were encountered: