Skip to content

sched: fix infinite loop if mblks_rem=0 initially #7004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

sched: fix infinite loop if mblks_rem=0 initially #7004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/discof/replay/fd_sched.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1268,9 +1268,10 @@ fd_sched_parse( fd_sched_t * sched, fd_sched_block_t * block, fd_sched_alut_ctx_
FD_TEST( block->fec_buf_soff==0U );
block->mblks_rem = FD_LOAD( ulong, block->fec_buf );
block->fec_buf_soff += (uint)sizeof(ulong);
/* FIXME what happens if someone sends us mblks_rem==0UL here? */

block->fec_sob = 0;
/* Treat a zero-count as an empty batch. This mirrors Agave's
behavior which allows empty batches (e.g. when no entries are
emitted). Do not leave the parser in mid-batch state. */
block->fec_sob = !block->mblks_rem;
continue;
}
if( block->txns_rem==0UL && block->mblks_rem==0UL ) {
Expand Down
Loading