Skip to content

Commit c12901f

Browse files
committed
flamenco, gossip: log when received no CRDS traffic (indicator for bad shred version)
1 parent 25d831f commit c12901f

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

src/flamenco/gossip/fd_gossip.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2356,6 +2356,14 @@ fd_gossip_log_stats( fd_gossip_t * glob, fd_pending_event_arg_t * arg ) {
23562356
FD_LOG_WARNING(("received no gossip packets!!"));
23572357
else
23582358
FD_LOG_INFO(("received %lu packets", glob->recv_pkt_cnt));
2359+
2360+
/* TODO: Come up with a better way to detect bad shred version */
2361+
if( fd_peer_table_key_cnt( glob->peers )!=0 &&
2362+
( glob->metrics.recv_message[ FD_METRICS_ENUM_GOSSIP_MESSAGE_V_PULL_RESPONSE_IDX ]==0 ||
2363+
glob->metrics.recv_message[ FD_METRICS_ENUM_GOSSIP_MESSAGE_V_PUSH_IDX ]==0 ) ) {
2364+
FD_LOG_WARNING(( "received no CRDS traffic! Likely bad shred version (current: %u)", glob->my_contact.ci->shred_version ));
2365+
}
2366+
23592367
glob->recv_pkt_cnt = 0;
23602368
FD_LOG_INFO(("received %lu dup values and %lu new", glob->recv_dup_cnt, glob->recv_nondup_cnt));
23612369
glob->recv_dup_cnt = glob->recv_nondup_cnt = 0;
@@ -2464,7 +2472,7 @@ fd_gossip_compact_values( fd_gossip_t * glob ) {
24642472
glob->need_push_head -= fd_ulong_if( push_head_snapshot != ULONG_MAX, push_head_snapshot, num_deleted );
24652473
fd_value_vec_contract( glob->values, num_deleted );
24662474
glob->metrics.value_vec_cnt = fd_value_vec_cnt( glob->values );
2467-
FD_LOG_NOTICE(( "GOSSIP compacted %lu values", num_deleted ));
2475+
FD_LOG_INFO(( "GOSSIP compacted %lu values", num_deleted ));
24682476
return num_deleted;
24692477
}
24702478

0 commit comments

Comments
 (0)