Fix missing funk API error handling

Author: riptl

src/discof/restart/fd_restart_tile.c

@@ -298,20 +298,18 @@ after_frag( fd_restart_tile_ctx_t * ctx,
     slot_bank->hard_forks.hard_forks_len = ctx->new_hard_forks_len;
 
     /* Write the slot bank back to funk, referencing fd_runtime_save_slot_bank */
-    int opt_err = 0;
+    int funk_err = 0;
     fd_funk_rec_prepare_t prepare[1];
-    fd_funk_rec_t * new_rec = fd_funk_rec_prepare( ctx->funk,
-                                                         funk_txn,
-                                                         &id,
-                                                         prepare,
-                                                         &opt_err );
+    fd_funk_rec_t * new_rec = fd_funk_rec_prepare(
+        ctx->funk, funk_txn, &id, prepare, &funk_err );
     if( FD_UNLIKELY( !new_rec ) ) {
-      FD_LOG_ERR(( "Wen-restart fails at inserting a hard fork in slot bank and save it in funk" ));
+      FD_LOG_ERR(( "fd_funk_rec_prepare() failed (%i-%s)", funk_err, fd_funk_strerror( funk_err ) ));
     }
 
-    ulong sz    = sizeof(uint) + fd_slot_bank_size( slot_bank );
-    uchar * buf = fd_funk_val_truncate( new_rec, sz, fd_funk_alloc( ctx->funk ), fd_funk_wksp( ctx->funk ), &opt_err );
-    *(uint*)buf = FD_RUNTIME_ENC_BINCODE;
+    ulong   sz  = sizeof(uint) + fd_slot_bank_size( slot_bank );
+    uchar * buf = fd_funk_val_truncate( new_rec, sz, fd_funk_alloc( ctx->funk ), fd_funk_wksp( ctx->funk ), &funk_err );
+    if( FD_UNLIKELY( !buf ) ) FD_LOG_ERR(( "fd_funk_val_truncate(sz=%lu) failed (%i-%s)", sz, funk_err, fd_funk_strerror( funk_err ) ));
+    FD_STORE( uint, buf, FD_RUNTIME_ENC_BINCODE );
     fd_bincode_encode_ctx_t slot_bank_encode_ctx = {
       .data    = buf + sizeof(uint),
       .dataend = buf + sz,

src/flamenco/runtime/fd_acc_mgr.c

@@ -92,11 +92,12 @@ fd_funk_get_acc_meta_mutable( fd_funk_t *             funk,
 
   ulong sz = sizeof(fd_account_meta_t)+min_data_sz;
   void * val;
-  if( fd_funk_val_sz( rec ) < sz )
+  if( fd_funk_val_sz( rec ) < sz ) {
     val = fd_funk_val_truncate( rec, sz, fd_funk_alloc( funk ), wksp, &funk_err );
-  else
+    if( FD_UNLIKELY( !val ) ) FD_LOG_ERR(( "fd_funk_val_truncate(sz=%lu) failed (%i-%s)", sz, funk_err, fd_funk_strerror( funk_err ) ));
+  } else {
     val = fd_funk_val( rec, wksp );
-
+  }
 
   if (NULL != opt_out_rec) {
     *opt_out_rec = rec;

src/flamenco/runtime/fd_runtime_init.c

@@ -24,8 +24,10 @@ fd_runtime_save_epoch_bank( fd_exec_slot_ctx_t * slot_ctx ) {
     return opt_err;
   }
 
-  uchar *buf = fd_funk_val_truncate(rec, sz, fd_funk_alloc( funk ), fd_funk_wksp(funk), NULL);
-  *(uint*)buf = FD_RUNTIME_ENC_BINCODE;
+  int funk_err = 0;
+  uchar * buf = fd_funk_val_truncate( rec, sz, fd_funk_alloc( funk ), fd_funk_wksp( funk ), &funk_err );
+  if( FD_UNLIKELY( !buf ) ) FD_LOG_ERR(( "fd_funk_val_truncate() failed (%i-%s)", funk_err, fd_funk_strerror( funk_err ) ));
+  FD_STORE( uint, buf, FD_RUNTIME_ENC_BINCODE );
   fd_bincode_encode_ctx_t ctx = {
       .data = buf + sizeof(uint),
       .dataend = buf + sz,
@@ -63,8 +65,10 @@ int fd_runtime_save_slot_bank( fd_exec_slot_ctx_t * slot_ctx ) {
     return opt_err;
   }
 
-  uchar * buf = fd_funk_val_truncate(rec, sz, fd_funk_alloc( funk ), fd_funk_wksp( funk ), NULL);
-  *(uint*)buf = FD_RUNTIME_ENC_BINCODE;
+  int funk_err = 0;
+  uchar * buf = fd_funk_val_truncate( rec, sz, fd_funk_alloc( funk ), fd_funk_wksp( funk ), &funk_err );
+  if( FD_UNLIKELY( !buf ) ) FD_LOG_ERR(( "fd_funk_val_truncate() failed (%i-%s)", funk_err, fd_funk_strerror( funk_err ) ));
+  FD_STORE( uint, buf, FD_RUNTIME_ENC_BINCODE );
   fd_bincode_encode_ctx_t ctx = {
       .data    = buf + sizeof(uint),
       .dataend = buf + sz,

src/flamenco/runtime/fd_txn_account.c

@@ -301,9 +301,12 @@ fd_txn_account_save( fd_txn_account_t * acct,
   ulong reclen = sizeof(fd_account_meta_t)+acct->private_state.const_meta->dlen;
   fd_wksp_t * wksp = fd_funk_wksp( funk );
   if( fd_funk_val_truncate( rec, reclen, fd_funk_alloc( funk ), wksp, &err ) == NULL ) {
-    FD_LOG_ERR(( "unable to allocate account value, err %d", err ));
+    FD_LOG_ERR(( "fd_funk_val_truncate(sz=%lu) for account failed (%i-%s)", reclen, err, fd_funk_strerror( err ) ));
   }
   err = fd_txn_account_save_internal( acct, funk );
+  if( FD_UNLIKELY( err ) ) {
+    FD_LOG_ERR(( "fd_txn_account_save_internal() failed (%i-%s)", err, fd_funk_strerror( err ) ));
+  }
 
   fd_funk_rec_publish( funk, prepare );
 

src/flamenco/runtime/program/fd_bpf_program_util.c

@@ -211,8 +211,17 @@ fd_bpf_create_bpf_program_cache_entry( fd_exec_slot_ctx_t *    slot_ctx,
       return -1;
     }
 
-    fd_wksp_t * wksp = fd_funk_wksp( funk );
-    void * val = fd_funk_val_truncate( rec, fd_sbpf_validated_program_footprint( &elf_info ), fd_funk_alloc( funk ), wksp, NULL );;
+    ulong val_sz = fd_sbpf_validated_program_footprint( &elf_info );
+    void * val = fd_funk_val_truncate(
+        rec,
+        val_sz,
+        fd_funk_alloc( funk ),
+        fd_funk_wksp( funk ),
+        &funk_err );
+    if( FD_UNLIKELY( funk_err ) ) {
+      FD_LOG_ERR(( "fd_funk_val_truncate(sz=%lu) for account failed (%i-%s)", val_sz, funk_err, fd_funk_strerror( funk_err ) ));
+    }
+
     fd_sbpf_validated_program_t * validated_prog = fd_sbpf_validated_program_new( val, &elf_info );
 
     ulong  prog_align     = fd_sbpf_program_align();