runtime: work around fixtures with dup blockhash

Author: riptl

src/flamenco/runtime/sysvar/fd_sysvar_epoch_schedule.c

@@ -34,7 +34,6 @@ void
 fd_sysvar_epoch_schedule_write( fd_exec_slot_ctx_t *        slot_ctx,
                                 fd_epoch_schedule_t const * epoch_schedule ) {
   ulong sz = fd_epoch_schedule_size( epoch_schedule );
-  FD_LOG_INFO(("Writing epoch schedule size %lu", sz));
   /* TODO remove alloca */
   uchar enc[ sz ];
   memset( enc, 0, sz );

src/flamenco/runtime/sysvar/fd_sysvar_last_restart_slot.c

@@ -8,7 +8,6 @@ void
 fd_sysvar_last_restart_slot_init( fd_exec_slot_ctx_t * slot_ctx ) {
 
   if( !FD_FEATURE_ACTIVE_BANK( slot_ctx->bank, last_restart_slot_sysvar ) ) {
-    FD_LOG_INFO(( "sysvar LastRestartSlot not supported by this ledger version!" ));
     return;
   }
 

src/flamenco/runtime/tests/harness/fd_exec_sol_compat.c

@@ -492,13 +492,14 @@ sol_compat_txn_fixture( fd_runtime_fuzz_runner_t * runner,
 
   int ok = 0;
   FD_SPAD_FRAME_BEGIN( runner->spad ) {
-  // Execute
-  void * output = NULL;
-  sol_compat_execute_wrapper( runner, &fixture->input, &output, fd_runtime_fuzz_txn_run );
-
-  // Compare effects
-  fd_exec_test_txn_result_t * effects = (fd_exec_test_txn_result_t *) output;
-  ok = sol_compat_cmp_txn( &fixture->output, effects );
+    // Execute
+    void * output = NULL;
+    sol_compat_execute_wrapper( runner, &fixture->input, &output, fd_runtime_fuzz_txn_run );
+    if( FD_LIKELY( output ) ) {
+      // Compare effects
+      fd_exec_test_txn_result_t * effects = output;
+      ok = sol_compat_cmp_txn( &fixture->output, effects );
+    }
   } FD_SPAD_FRAME_END;
 
   // Cleanup

src/flamenco/runtime/tests/harness/fd_txn_harness.c

@@ -88,17 +88,17 @@ fd_runtime_fuzz_txn_ctx_create( fd_runtime_fuzz_runner_t *         runner,
 
   /* Set epoch bank variables if not present (defaults obtained from GenesisConfig::default() in Agave) */
   fd_epoch_schedule_t default_epoch_schedule = {
-                                                .slots_per_epoch             = 432000,
-                                                .leader_schedule_slot_offset = 432000,
-                                                .warmup                      = 1,
-                                                .first_normal_epoch          = 14,
-                                                .first_normal_slot           = 524256
-                                               };
-  fd_rent_t           default_rent           = {
-                                                .lamports_per_uint8_year     = 3480,
-                                                .exemption_threshold         = 2.0,
-                                                .burn_percent                = 50
-                                               };
+    .slots_per_epoch             = 432000,
+    .leader_schedule_slot_offset = 432000,
+    .warmup                      = 1,
+    .first_normal_epoch          = 14,
+    .first_normal_slot           = 524256
+  };
+  fd_rent_t default_rent = {
+    .lamports_per_uint8_year = 3480,
+    .exemption_threshold     = 2.0,
+    .burn_percent            = 50
+  };
   fd_bank_epoch_schedule_set( slot_ctx->bank, default_epoch_schedule );
 
   fd_bank_rent_set( slot_ctx->bank, default_rent );
@@ -195,7 +195,7 @@ fd_runtime_fuzz_txn_ctx_create( fd_runtime_fuzz_runner_t *         runner,
 
   /* Blockhash queue init */
   ulong blockhash_seed; FD_TEST( fd_rng_secure( &blockhash_seed, sizeof(ulong) ) );
-  fd_blockhashes_init( fd_bank_block_hash_queue_modify( slot_ctx->bank ), blockhash_seed );
+  fd_blockhashes_t * blockhashes = fd_blockhashes_init( fd_bank_block_hash_queue_modify( slot_ctx->bank ), blockhash_seed );
 
   // Save lamports per signature for most recent blockhash, if sysvar cache contains recent block hashes
   fd_recent_block_hashes_t const * rbh_sysvar = fd_sysvar_recent_hashes_read( funk, funk_txn, runner->spad );
@@ -219,10 +219,14 @@ fd_runtime_fuzz_txn_ctx_create( fd_runtime_fuzz_runner_t *         runner,
     memcpy( genesis_hash->hash, test_ctx->blockhash_queue[0]->bytes, sizeof(fd_hash_t) );
 
     for( ulong i = 0; i < num_blockhashes; ++i ) {
+      fd_hash_t blockhash = FD_LOAD( fd_hash_t, test_ctx->blockhash_queue[i]->bytes );
+      /* Drop duplicate blockhashes */
+      if( FD_UNLIKELY( fd_blockhash_map_idx_remove( blockhashes->map, &blockhash, ULONG_MAX, blockhashes->d.deque )!=ULONG_MAX ) ) {
+        FD_LOG_WARNING(( "Fuzz input has a duplicate blockhash %s at index %lu",
+                         FD_BASE58_ENC_32_ALLOCA( blockhash.hash ), i ));
+      }
       // Recent block hashes cap is 150 (actually 151), while blockhash queue capacity is 300 (actually 301)
-      fd_block_block_hash_entry_t blockhash_entry;
-      memcpy( &blockhash_entry.blockhash, test_ctx->blockhash_queue[i]->bytes, sizeof(fd_hash_t) );
-      fd_bank_poh_set( slot_ctx->bank, blockhash_entry.blockhash );
+      fd_bank_poh_set( slot_ctx->bank, blockhash );
       fd_sysvar_recent_hashes_update( slot_ctx, runner->spad );
     }
   } else {