Skip to content

Commit cc53056

Browse files
author
Jonathan Woollett-Light
authored
Merge branch 'main' into clippy_cast_lossless
2 parents 5307637 + 4f853c8 commit cc53056

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

docs/devctr-image.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ registry. The Firecracker CI suite must also be updated to use the new image.
3535

3636
```bash
3737
docker login --username AWS --password \
38-
$(aws ecr-public get-login-password) public.ecr.aws
38+
$(aws ecr-public get-login-password --region us-east-1) public.ecr.aws
3939
```
4040

4141
1. Navigate to the Firecracker directory. Verify that you have the latest

docs/getting-started.md

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,17 @@ arguments is available via:
314314
tools/devtool --help
315315
```
316316

317+
### Alternative: Building Firecracker without devtool
318+
319+
It is possible to build Firecracker without invoking `devtool` by instead
320+
running `cargo build`. However, binaries generated like this should not
321+
be used in production and are considered experimental.
322+
323+
Note that the default target for Firecracker is `x86_64-unknown-linux-musl`
324+
(set in `.cargo/config`). If you want to build an ARM binary, you need to
325+
pass `--target aarch64-unknown-linux-musl` to `cargo build`, even if
326+
compiling on an ARM machine. Otherwise it will try to build an `x86_64` binary.
327+
317328
### Alternative: Building Firecracker using glibc
318329

319330
The toolchain that Firecracker is tested against and that is recommended for
@@ -331,9 +342,8 @@ arch=`uname -m`
331342
cargo build --target ${arch}-unknown-linux-gnu
332343
```
333344

334-
That being said, Firecracker binaries linked with glibc or built without
335-
`devtool` are always considered experimental and should not be used in
336-
production.
345+
That being said, Firecracker binaries linked with glibc are always considered
346+
experimental and should not be used in production.
337347

338348
## Running the Integration Test Suite
339349

0 commit comments

Comments
 (0)