Address feedback

Author: a-maurice

vertexai/src/GenerateContentResponse.cs

@@ -45,7 +45,7 @@ public readonly struct GenerateContentResponse {
   public UsageMetadata? UsageMetadata { get; }
 
   /// <summary>
-  /// The response's content as text, if it exists
+  /// The response's content as text, if it exists.
   /// </summary>
   public string Text {
     get {
@@ -57,7 +57,7 @@ public string Text {
   }
 
   /// <summary>
-  /// Returns function calls found in any Parts of the first candidate of the response, if any.
+  /// Returns function calls found in any `Part`s of the first candidate of the response, if any.
   /// </summary>
   public IEnumerable<ModelContent.FunctionCallPart> FunctionCalls {
     get {

vertexai/src/GenerativeModel.cs

@@ -34,7 +34,7 @@ namespace Firebase.VertexAI {
 public class GenerativeModel {
   private FirebaseApp _firebaseApp;
 
-  // Various setting fields provided by the user
+  // Various setting fields provided by the user.
   private string _location;
   private string _modelName;
   private GenerationConfig? _generationConfig;
@@ -73,7 +73,7 @@ internal GenerativeModel(FirebaseApp firebaseApp,
 
 #region Public API
   /// <summary>
-  /// Generates new content from input ModelContent given to the model as a prompt.
+  /// Generates new content from input `ModelContent` given to the model as a prompt.
   /// </summary>
   /// <param name="content">The input(s) given to the model as a prompt.</param>
   /// <returns>The generated content response from the model.</returns>
@@ -93,7 +93,7 @@ public Task<GenerateContentResponse> GenerateContentAsync(
     return GenerateContentAsync(new ModelContent[] { ModelContent.Text(text) });
   }
   /// <summary>
-  /// Generates new content from input ModelContent given to the model as a prompt.
+  /// Generates new content from input `ModelContent` given to the model as a prompt.
   /// </summary>
   /// <param name="content">The input(s) given to the model as a prompt.</param>
   /// <returns>The generated content response from the model.</returns>

vertexai/src/ModelContent.cs

@@ -23,44 +23,44 @@ namespace Firebase.VertexAI {
 
 /// <summary>
 /// A type describing data in media formats interpretable by an AI model. Each generative AI
-/// request or response contains a list of ``ModelContent``s, and each ``ModelContent`` value
-/// may comprise multiple heterogeneous ``ModelContent.Part``s.
+/// request or response contains a list of `ModelContent`s, and each `ModelContent` value
+/// may comprise multiple heterogeneous `ModelContent.Part`s.
 /// </summary>
 public readonly struct ModelContent {
   private readonly string _role;
   private readonly ReadOnlyCollection<Part> _parts;
 
   /// <summary>
-  /// The role of the entity creating the ``ModelContent``. For user-generated client requests,
+  /// The role of the entity creating the `ModelContent`. For user-generated client requests,
   /// for example, the role is `user`.
   /// </summary>
   public string Role => string.IsNullOrWhiteSpace(_role) ? "user" : _role;
 
   /// <summary>
-  /// The data parts comprising this ``ModelContent`` value.
+  /// The data parts comprising this `ModelContent` value.
   /// </summary>
   public IEnumerable<Part> Parts => _parts ?? new ReadOnlyCollection<Part>(new List<Part>());
 
   /// <summary>
-  /// Creates a ModelContent with the given `Part`s, using the default `user` role.
+  /// Creates a `ModelContent` with the given `Part`s, using the default `user` role.
   /// </summary>
   public ModelContent(params Part[] parts) : this("user", parts) { }
 
   /// <summary>
-  /// Creates a ModelContent with the given `Part`s, using the default `user` role.
+  /// Creates a `ModelContent` with the given `Part`s, using the default `user` role.
   /// </summary>
   public ModelContent(IEnumerable<Part> parts) : this("user", parts) { }
 
   /// <summary>
-  /// Creates a ModelContent with the given role and `Part`s.
+  /// Creates a `ModelContent` with the given role and `Part`s.
   /// </summary>
   public ModelContent(string role, params Part[] parts) {
     _role = role;
     _parts = new ReadOnlyCollection<Part>(parts.ToList());
   }
 
   /// <summary>
-  /// Creates a ModelContent with the given role and `Part`s.
+  /// Creates a `ModelContent` with the given role and `Part`s.
   /// </summary>
   public ModelContent(string role, IEnumerable<Part> parts) {
     _role = role;
@@ -70,32 +70,32 @@ public ModelContent(string role, IEnumerable<Part> parts) {
 #region Helper Factories
 
   /// <summary>
-  /// Creates a new ModelContent with the default `user` role, and a
-  /// TextPart containing the given text.
+  /// Creates a new `ModelContent` with the default `user` role, and a
+  /// `TextPart` containing the given text.
   /// </summary>
   public static ModelContent Text(string text) {
     return new ModelContent(new TextPart(text));
   }
 
   /// <summary>
-  /// Creates a new ModelContent with the default `user` role, and an
-  /// InlineDataPart containing the given mimeType and data.
+  /// Creates a new `ModelContent` with the default `user` role, and an
+  /// `InlineDataPart` containing the given mimeType and data.
   /// </summary>
   public static ModelContent InlineData(string mimeType, byte[] data) {
     return new ModelContent(new InlineDataPart(mimeType, data));
   }
 
   /// <summary>
-  /// Creates a new ModelContent with the default `user` role, and a
-  /// FileDataPart containing the given mimeType and data.
+  /// Creates a new `ModelContent` with the default `user` role, and a
+  /// `FileDataPart` containing the given mimeType and data.
   /// </summary>
   public static ModelContent FileData(string mimeType, System.Uri uri) {
     return new ModelContent(new FileDataPart(mimeType, uri));
   }
 
   /// <summary>
-  /// Creates a new ModelContent with the default `user` role, and a
-  /// FunctionResponsePart containing the given name and args.
+  /// Creates a new `ModelContent` with the default `user` role, and a
+  /// `FunctionResponsePart` containing the given name and args.
   /// </summary>
   public static ModelContent FunctionResponse(
       string name, IDictionary<string, object> response) {
@@ -111,12 +111,12 @@ public static ModelContent FunctionResponse(
 
   /// <summary>
   /// A discrete piece of data in a media format interpretable by an AI model. Within a
-  /// single value of ``Part``, different data types may not mix.
+  /// single value of `Part`, different data types may not mix.
   /// </summary>
   public interface Part {
 #if !DOXYGEN
     /// <summary>
-    /// Intended for internal use only
+    /// Intended for internal use only.
     /// </summary>
     Dictionary<string, object> ToJson();
 #endif
@@ -151,7 +151,7 @@ Dictionary<string, object> Part.ToJson() {
   }
 
   /// <summary>
-  /// File data stored in Cloud Storage for Firebase, referenced by URI.
+  /// File data stored in Cloud Storage for Firebase, referenced by a URI.
   /// </summary>
   public readonly struct FileDataPart : Part {
     public string MimeType { get; }
@@ -201,7 +201,7 @@ Dictionary<string, object> Part.ToJson() {
   ///
   /// Contains a string representing the `FunctionDeclaration.name` and a structured JSON object
   /// containing any output from the function is used as context to the model. This should contain the
-  /// result of a ``FunctionCallPart`` made based on model prediction.
+  /// result of a `FunctionCallPart` made based on model prediction.
   /// </summary>
   public readonly struct FunctionResponsePart : Part {
     public string Name { get; }
@@ -262,7 +262,7 @@ private static Part PartFromJson(Dictionary<string, object> jsonDict) {
       if (!functionCallDict.TryGetValue("name", out var name) || name is not string) {
         throw new VertexAISerializationException("Invalid JSON format: 'name' is not a string.");
       }
-      if (!functionCallDict.TryGetValue("name", out var args) || args is not Dictionary<string, object>) {
+      if (!functionCallDict.TryGetValue("args", out var args) || args is not Dictionary<string, object>) {
         throw new VertexAISerializationException("Invalid JSON format: 'args' is not a dictionary.");
       }
       return new FunctionCallPart(name as string, args as Dictionary<string, object>);

vertexai/src/RequestOptions.cs

@@ -22,7 +22,7 @@ namespace Firebase.VertexAI {
 /// Configuration parameters for sending requests to the backend.
 /// </summary>
 public readonly struct RequestOptions {
-  // Since the user could create RequestOptions with the default constructor,
+  // Since the user could create `RequestOptions` with the default constructor,
   // which isn't hidable in our C# version, we default to null, and use that
   // to determine if it should be 180.
   private readonly TimeSpan? _timeout;
@@ -33,7 +33,7 @@ public readonly struct RequestOptions {
   internal TimeSpan Timeout => _timeout ?? DefaultTimeout;
 
   /// <summary>
-  /// Initialize a request options object.
+  /// Initialize a `RequestOptions` object.
   /// </summary>
   /// <param name="timeout">The request's timeout interval. Defaults to 180 seconds if given null.</param>
   public RequestOptions(TimeSpan? timeout = null) {

vertexai/src/VertexAI.cs

@@ -35,7 +35,7 @@ private VertexAI(FirebaseApp firebaseApp, string location) {
   }
 
   /// <summary>
-  /// Returns a VertexAI initialized with the default `FirebaseApp` and location.
+  /// Returns a `VertexAI` instance initialized with the default `FirebaseApp` and location.
   /// </summary>
   public static VertexAI DefaultInstance => GetInstance();
 
@@ -51,7 +51,7 @@ public static VertexAI GetInstance(string location = "us-central1") {
   }
 
   /// <summary>
-  /// Creates an instance of `VertexAI` configured with the given FirebaseApp and location.
+  /// Creates an instance of `VertexAI` configured with the given `FirebaseApp` and location.
   /// </summary>
   /// <param name="app">The custom `FirebaseApp` used for initialization.</param>
   /// <param name="location">The region identifier, defaulting to `us-central1`; see [Vertex AI