[Analytics] Remove AnalyticsSwift (#13056)

Author: ncooke3

CoreOnly/Tests/FirebasePodTest/FirebasePodTest/AppDelegate.swift

@@ -15,7 +15,7 @@
 import Firebase
 
 // Verify that the following Firebase Swift APIs can be found.
-import FirebaseAnalyticsSwift
+import FirebaseAnalytics
 import FirebaseFirestoreSwift
 import FirebaseInAppMessaging
 import UIKit

CoreOnly/Tests/FirebasePodTest/Podfile

@@ -11,7 +11,6 @@ target 'FirebasePodTest' do
 
   pod 'Firebase', :path => '../../../'
   pod 'FirebaseABTesting', :path => '../../../'
-  pod 'FirebaseAnalyticsSwift', :path => '../../../'
   pod 'FirebaseAppDistribution', :path => '../../../'
   pod 'FirebaseAuth', :path => '../../../'
   pod 'FirebaseCore', :path => '../../../'

Dangerfile

@@ -108,12 +108,10 @@ has_license_changes = didModify(["LICENSE"])
 ## Product directories
 @has_analytics_changes = hasChangesIn([
   "FirebaseAnalyticsOnDeviceConversionWrapper",
-  "FirebaseAnalyticsSwift",
   "FirebaseAnalyticsWithoutAdIdSupportWrapper",
   "FirebaseAnalyticsWrapper"
 ]) || didModify([
   "FirebaseAnalytics.podspec",
-  "FirebaseAnalyticsSwift.podspec",
   "FirebaseAnalyticsOnDeviceConversion.podspec",
   "GoogleAppMeasurement.podspec",
   "GoogleAppMeasurementOnDeviceConversion.podspec"

FirebaseAnalytics/README.md

@@ -1,2 +1,111 @@
-This directory open sources select files from the Firebase Analytics SDK. Note
-that there is no open source infrastructure to build or package them.
+# Firebase Analytics SDK
+
+Introduce a manual screen view event logging API that enable developers to log individual views in SwiftUI lifecycle.
+
+## Code Samples
+
+### Before
+```swift
+
+struct ContentView: View {
+  var body: some View {
+    Text("Hello, world!")
+      // Logging screen name with class and a custom parameter.
+      .onAppear {
+        Analytics.logEvent(AnalyticsEventScreenView,
+                           parameters: [AnalyticsParameterScreenName: "main_content",
+                                        AnalyticsParameterScreenClass: "ContentView",
+                                        "my_custom_param": 5])
+      }
+
+       // OR Logging screen name only.
+      .onAppear {
+        Analytics.logEvent(AnalyticsEventScreenView,
+                           parameters: [AnalyticsParameterScreenName: "main_content"])
+      }
+  }
+}
+
+```
+
+### After
+```swift
+struct ContentView: View {
+  var body: some View {
+    Text("Hello, world!")
+       // Logging screen name with class and a custom parameter.
+      .analyticsScreen(name: "main_content",
+                       class: "ContentView",
+                       extraParameters: ["my_custom_param": 5])
+
+      // OR Logging screen name only, class and extra parameters are optional.
+      .analyticsScreen(name: "main_content")
+  }
+}
+```
+An example that demonstrates how the custom event logging API and manual screen view event logging API can make the code more efficient and reduce the number of lines required for event logging.
+
+### Before (Without APIs)
+
+```swift
+struct ContentView: View {
+    var body: some View {
+        VStack {
+            Text("Welcome to our App!")
+                .padding()
+            Button("Click Me!") {
+                // Logging a custom event when the button is clicked.
+                Analytics.logEvent("button_clicked", parameters: nil)
+            }
+        }
+        .onAppear {
+            // Logging the screen view event when the ContentView appears.
+            Analytics.logEvent(AnalyticsEventScreenView, parameters: [AnalyticsParameterScreenName: "main_content"])
+        }
+    }
+}
+```
+
+### After (With APIs)
+
+```swift
+struct ContentView: View {
+    var body: some View {
+        VStack {
+            Text("Welcome to our App!")
+                .padding()
+            Button("Click Me!") {
+                // Directly using Firebase's logEvent method to log the button click.
+                Analytics.logEvent("button_clicked", parameters: nil)
+            }
+        }
+        // Using the new manual screen view event logging API to log the screen view.
+        .analyticsScreen(name: "main_content")
+    }
+}
+
+
+// Introducing a manual screen view event logging API.
+extension View {
+    func analyticsScreen(name: String, class screenClass: String? = nil, extraParameters: [String: Any]? = nil) -> some View {
+        onAppear {
+            var params: [String: Any] = [AnalyticsParameterScreenName: name]
+            if let screenClass {
+                params[AnalyticsParameterScreenClass] = screenClass
+            }
+            if let extraParameters {
+                params.merge(extraParameters) { _, new in new }
+            }
+            Analytics.logEvent(AnalyticsEventScreenView, parameters: params)
+        }
+    }
+}
+```
+
+In this example, by leveraging the custom event logging API and manual screen view event logging API, we achieve a significant reduction in code complexity for event tracking:
+
+1. **Before:** In the previous implementation, event logging for button clicks and screen views required separate blocks of code, leading to redundant lines of code throughout the
+app. This redundancy made the codebase less efficient and harder to maintain.
+
+2. **After:** By adopting the event logging API and manual screen view event logging API, we now condense the event tracking logic into just a few lines of code. This streamlined
+approach improves the overall code efficiency and enhances code readability.

FirebaseAnalytics/Analytics+SwiftUI.swift renamed to FirebaseAnalytics/Sources/Analytics+SwiftUI.swift

@@ -0,0 +1,2 @@
+This directory open sources select files from the Firebase Analytics SDK. Note
+that there is no open source infrastructure to build or package them.

FirebaseAnalytics/Sources/README.md

@@ -21,7 +21,6 @@ import StoreKit
 import SwiftUI
 
 import FirebaseAnalytics
-import FirebaseAnalyticsSwift
 import SwiftUI
 
 final class AnalyticsAPITests {

FirebaseAnalyticsSwift/Tests/ObjCAPI/ObjCAPITests.m renamed to FirebaseAnalytics/Tests/ObjCAPI/ObjCAPITests.m

@@ -9,7 +9,6 @@ target 'SwiftUISample' do
   # Comment the next line if you don't want to use dynamic frameworks
   use_frameworks!
   pod 'FirebaseAnalytics'
-  pod 'FirebaseAnalyticsSwift'
   pod 'FirebaseCore', :path => '../../../'
   pod 'FirebaseCoreInternal', :path => '../../../'
   pod 'FirebaseInstallations', :path => '../../../'

FirebaseAnalyticsSwift/Tests/SwiftUnit/AnalyticsAPITests.swift renamed to FirebaseAnalytics/Tests/SwiftUnit/AnalyticsAPITests.swift

@@ -15,7 +15,6 @@
  */
 
 import FirebaseAnalytics
-import FirebaseAnalyticsSwift
 import FirebaseRemoteConfig
 import FirebaseRemoteConfigSwift
 import SwiftUI