Fixes logging of unhandled exceptions in callable functions. (#759)

mbleigh · web-flow · commit 84433df63147 · 2020-08-12T10:27:37.000-07:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1 +1,2 @@
 - Updates `firebase-admin` dependency to support `^9.0.0` in addition to `^8.0.0`. Note that `firebase-admin` no longer supports Node.js 8.x as of `9.0.0`.
+- Fixes logging of unexpected errors in `https.onCall()` functions.
diff --git a/src/providers/https.ts b/src/providers/https.ts
@@ -469,7 +469,7 @@ export function _onCallWithOptions(
     } catch (err) {
       if (!(err instanceof HttpsError)) {
         // This doesn't count as an 'explicit' error.
-        error('Unhandled error', error);
+        error('Unhandled error', err);
         err = new HttpsError('internal', 'INTERNAL');
       }
 

Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
`1`	`1`	- Updates `firebase-admin` dependency to support `^9.0.0` in addition to `^8.0.0`. Note that `firebase-admin` no longer supports Node.js 8.x as of `9.0.0`.
	`2`	+- Fixes logging of unexpected errors in `https.onCall()` functions.
Original file line number	Diff line number	Diff line change
`@@ -469,7 +469,7 @@ export function _onCallWithOptions(`
`469`	`469`	`} catch (err) {`
`470`	`470`	`if (!(err instanceof HttpsError)) {`
`471`	`471`	`// This doesn't count as an 'explicit' error.`
`472`		`- error('Unhandled error', error);`
	`472`	`+ error('Unhandled error', err);`
`473`	`473`	`err = new HttpsError('internal', 'INTERNAL');`
`474`	`474`	`}`
`475`	`475`