Skip to content

Commit 6068832

Browse files
authored
uncomment integration tests for node 10 (#464)
1 parent 59d6a7e commit 6068832

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

integration_test/run_tests.sh

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -141,15 +141,14 @@ if [[ $PROJECT_ID_NODE_8 == $PROJECT_ID_NODE_10 ]]; then
141141
waitForPropagation
142142
run_tests
143143
fi
144-
# TODO(b/134418760): Uncomment this when Node 10 issues are fixed
145-
# pick_node10
146-
# announce "Re-deploying the same functions to Node 10 runtime ..."
147-
# deploy
148-
# waitForPropagation
149-
# if [[ $PROJECT_ID_NODE_8 == $PROJECT_ID_NODE_10 ]]; then
150-
# run_tests
151-
# else
152-
# run_all_tests
153-
# fi
144+
pick_node10
145+
announce "Re-deploying the same functions to Node 10 runtime ..."
146+
deploy
147+
waitForPropagation
148+
if [[ $PROJECT_ID_NODE_8 == $PROJECT_ID_NODE_10 ]]; then
149+
run_tests
150+
else
151+
run_all_tests
152+
fi
154153
cleanup
155154
announce "All tests pass!"

0 commit comments

Comments
 (0)