Migrate to v5.13.0 firebase-admin & new Firestore timestamp format (#207)

Author: laurenzlong

package.json

@@ -40,7 +40,7 @@
     "@types/sinon": "^1.16.29",
     "chai": "^3.5.0",
     "chai-as-promised": "^5.2.0",
-    "firebase-admin": "~5.12.1",
+    "firebase-admin": "~5.13.0",
     "istanbul": "^0.4.2",
     "mocha": "^2.4.5",
     "mock-require": "^2.0.1",
@@ -50,7 +50,7 @@
     "typescript": "~2.8.3"
   },
   "peerDependencies": {
-    "firebase-admin": "~5.12.1"
+    "firebase-admin": "~5.13.0"
   },
   "dependencies": {
     "@types/cors": "^2.8.1",

spec/providers/firestore.spec.ts

@@ -500,21 +500,18 @@ describe('Firestore Functions', () => {
       });
 
       it('should support #createTime', () => {
-        expect(Date.parse(snapshot.createTime)).to.equal(
-          Date.parse('2017-06-17T14:45:17.876479Z')
-        );
+        expect(snapshot.createTime.seconds).to.be.a('number');
+        expect(snapshot.createTime.nanoseconds).to.be.a('number');
       });
 
       it('should support #updateTime', () => {
-        expect(Date.parse(snapshot.updateTime)).to.equal(
-          Date.parse('2017-08-31T18:05:26.928527Z')
-        );
+        expect(snapshot.updateTime.seconds).to.be.a('number');
+        expect(snapshot.updateTime.nanoseconds).to.be.a('number');
       });
 
       it('should support #readTime', () => {
-        expect(Date.parse(snapshot.readTime)).to.equal(
-          Date.parse('2017-07-31T18:23:26.928527Z')
-        );
+        expect(snapshot.readTime.seconds).to.be.a('number');
+        expect(snapshot.readTime.nanoseconds).to.be.a('number');
       });
     });
 

src/providers/firestore.ts

@@ -145,6 +145,7 @@ function _getValueProto(data: any, resource: string, valueFieldName: string) {
 export function snapshotConstructor(event: Event): DocumentSnapshot {
   if (!firestoreInstance) {
     firestoreInstance = firebase.firestore(apps().admin);
+    firestoreInstance.settings({ timestampsInSnapshots: true });
   }
   let valueProto = _getValueProto(
     event.data,

src/providers/https.ts

@@ -45,7 +45,7 @@ export function onRequest(
  */
 export function onCall(
   handler: (data: any, context: CallableContext) => any | Promise<any>
-) {
+): HttpsFunction & Runnable<any> {
   return _onCallWithOpts(handler, {});
 }
 

tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "lib": ["es6"],
     "module": "commonjs",
-    "noImplicitAny": true,
+    "noImplicitAny": false,
     "outDir": ".tmp",
     "sourceMap": true,
     "target": "es6",