Skip to content

Commit ed218ad

Browse files
committed
fix: add noqa comments and explanations for re-exported imports
- Add clear comments explaining why Timezone and AlertType are re-exported - Add noqa: F401 to suppress unused import warnings for intentional re-exports - Fix import ordering to satisfy ruff
1 parent 50ae428 commit ed218ad

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

.gitignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,3 +139,8 @@ doc/dist
139139
.idea
140140
.vscode/*
141141
!.vscode/settings.json
142+
143+
# Local development files
144+
async.md
145+
modernization.md
146+
uv.lock

src/firebase_functions/alerts_fn.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,12 @@
2727
from firebase_functions.core import CloudEvent as _CloudEvent
2828
from firebase_functions.core import T, _with_init
2929

30-
# Explicitly import AlertType to make it available in the public API.
31-
# pylint: disable=unused-import
32-
from firebase_functions.options import AlertType, FirebaseAlertOptions
30+
# Re-export AlertType from options module so users can import it directly from alerts_fn
31+
# This provides a more convenient API: from firebase_functions.alerts_fn import AlertType
32+
from firebase_functions.options import (
33+
AlertType, # noqa: F401
34+
FirebaseAlertOptions,
35+
)
3336

3437

3538
@_dataclasses.dataclass(frozen=True)

src/firebase_functions/scheduler_fn.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@
3333
import firebase_functions.private.util as _util
3434
from firebase_functions.core import _with_init
3535

36-
# Export for user convenience.
37-
# pylint: disable=unused-import
38-
from firebase_functions.options import Timezone
36+
# Re-export Timezone from options module so users can import it directly from scheduler_fn
37+
# This provides a more convenient API: from firebase_functions.scheduler_fn import Timezone
38+
from firebase_functions.options import Timezone # noqa: F401
3939

4040

4141
@_dataclasses.dataclass(frozen=True)

0 commit comments

Comments
 (0)