Skip to content

Commit c4264fd

Browse files
committed
No subclassing
1 parent b328d02 commit c4264fd

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

firestore/src/include/firebase/firestore/local_cache_settings.h

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,10 @@ class LocalCacheSettings {
5252
private:
5353
friend class FirestoreInternal;
5454
friend class Settings;
55+
friend class PersistentCacheSettings;
56+
friend class MemoryCacheSettings;
57+
58+
LocalCacheSettings() = default;
5559

5660
virtual Kind kind() const = 0;
5761
virtual const LocalCacheSettingsInternal& internal() const = 0;
@@ -87,7 +91,7 @@ class PersistentCacheSettings final : public LocalCacheSettings {
8791
* cleanup will be attempted.
8892
*
8993
* By default, persistence cache is enabled with a cache size of 100 MB. The
90-
* minimum value is 1 MB.
94+
* minimum value is 1 MB (1 * 1024 * 1024 bytes).
9195
*/
9296
PersistentCacheSettings WithSizeBytes(int64_t size) const;
9397

@@ -248,7 +252,7 @@ class MemoryLruGCSettings final : public MemoryGarbageCollectorSettings {
248252
* cleanup will be attempted.
249253
*
250254
* By default, memory LRU cache is enabled with a cache size of 100 MB. The
251-
* minimum value is 1 MB.
255+
* minimum value is 1 MB (1 * 1024 * 1024 bytes).
252256
*/
253257
MemoryLruGCSettings WithSizeBytes(int64_t size);
254258

0 commit comments

Comments
 (0)