Skip to content

Commit b186c24

Browse files
authored
Add missing Remote Config classes to proguard (#1350)
* Add missing Remote Config classes to proguard * Update readme.md
1 parent c3afeae commit b186c24

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

release_build_files/readme.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -630,6 +630,8 @@ code.
630630
### Upcoming Release
631631
- Changes
632632
- App Check (Desktop): Fixed expired tokens being cached on 32-bit systems.
633+
- Remote Config (Android): Fixed the ConfigUpdate classes being missing
634+
from the proguard files.
633635
- Remote Config (Desktop): Fixed handling of time zones on Windows when the
634636
time zone name in the current system language contains an accented
635637
character or apostrophe. This adds a requirement for applications using

remote_config/src/android/remote_config_android.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ METHOD_LOOKUP_DECLARATION(jni_config_update_listener,
171171
JNI_CONFIG_UPDATE_LISTENER_METHODS)
172172
METHOD_LOOKUP_DEFINITION(
173173
jni_config_update_listener,
174+
PROGUARD_KEEP_CLASS
174175
"com/google/firebase/remoteconfig/internal/cpp/JniConfigUpdateListener",
175176
JNI_CONFIG_UPDATE_LISTENER_METHODS)
176177

@@ -195,6 +196,7 @@ static const JNINativeMethod kNativeJniConfigUpdateListenerMethods[] = {
195196

196197
METHOD_LOOKUP_DECLARATION(config_update, CONFIG_UPDATE_METHODS)
197198
METHOD_LOOKUP_DEFINITION(config_update,
199+
PROGUARD_KEEP_CLASS
198200
"com/google/firebase/remoteconfig/ConfigUpdate",
199201
CONFIG_UPDATE_METHODS)
200202

@@ -208,6 +210,7 @@ METHOD_LOOKUP_DECLARATION(config_update_listener_registration,
208210
CONFIG_UPDATE_LISTENER_REGISTRATION_METHODS)
209211
METHOD_LOOKUP_DEFINITION(
210212
config_update_listener_registration,
213+
PROGUARD_KEEP_CLASS
211214
"com/google/firebase/remoteconfig/ConfigUpdateListenerRegistration",
212215
CONFIG_UPDATE_LISTENER_REGISTRATION_METHODS)
213216

0 commit comments

Comments
 (0)