Skip to content

Commit b09e4d8

Browse files
authored
Update Test Devices & other minor fixes (#1109)
1 parent 77062b5 commit b09e4d8

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

.github/workflows/integration_tests.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,6 @@ jobs:
196196
echo "matrix_os=$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${TEST_MATRIX_PARAM} -k os -o "${{github.event.inputs.operating_systems}}")" >> $GITHUB_OUTPUT
197197
echo "matrix_arch_macos=$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${TEST_MATRIX_PARAM} -k architecture_macos)" >> $GITHUB_OUTPUT
198198
echo "matrix_arch_windows_linux=$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${TEST_MATRIX_PARAM} -k architecture_windows_linux)" >> $GITHUB_OUTPUT
199-
200199
# Combine architecture_macos and architecture_windows_linux to get a list of all architectures for the build matrix.
201200
matrix_arch_combined=`echo $( python scripts/gha/print_matrix_configuration.py -w integration_tests ${TEST_MATRIX_PARAM} -k architecture_macos | sed 's/[]\[,]//g') \
202201
$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${TEST_MATRIX_PARAM} -k architecture_windows_linux | sed 's/[]\[,]//g' ) \
@@ -219,7 +218,6 @@ jobs:
219218
echo "xcode_version=$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${TEST_MATRIX_PARAM} -k xcode_version)" >> $GITHUB_OUTPUT
220219
echo "ios_device=$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${TEST_MATRIX_PARAM} -k ios_device -t ${mobile_test_on} )" >> $GITHUB_OUTPUT
221220
echo "tvos_device=$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${TEST_MATRIX_PARAM} -k tvos_device -t ${mobile_test_on} )" >> $GITHUB_OUTPUT
222-
223221
- name: Update PR label and comment
224222
if: steps.set_outputs.outputs.pr_number
225223
shell: bash
@@ -1043,7 +1041,7 @@ jobs:
10431041
max_attempts: 3
10441042
validator: ${GITHUB_WORKSPACE}/scripts/gha/integration_testing/ftl_gha_validator.py
10451043
- name: Read FTL Test Result
1046-
if: steps.device-info.outputs.device_type == 'real'
1044+
if: ${{ steps.device-info.outputs.device_type == 'real' && !cancelled() }}
10471045
shell: bash
10481046
run: |
10491047
python scripts/gha/read_ftl_test_result.py --test_result '${{ steps.ftl_test.outputs.test_summary }}' \
@@ -1186,7 +1184,7 @@ jobs:
11861184
max_attempts: 3
11871185
validator: ${GITHUB_WORKSPACE}/scripts/gha/integration_testing/ftl_gha_validator.py
11881186
- name: Read FTL Test Result
1189-
if: steps.device-info.outputs.device_type == 'real'
1187+
if: ${{ steps.device-info.outputs.device_type == 'real' && !cancelled() }}
11901188
shell: bash
11911189
run: |
11921190
python scripts/gha/read_ftl_test_result.py --test_result '${{ steps.ftl_test.outputs.test_summary }}' \

scripts/gha/github.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
BACKOFF = 5
3232
RETRY_STATUS = (403, 500, 502, 504)
3333
TIMEOUT = 5
34+
TIMEOUT_LONG = 20
3435

3536
OWNER = 'firebase'
3637
REPO = 'firebase-cpp-sdk'
@@ -236,9 +237,9 @@ def list_workflows(token, workflow_id, branch):
236237
"""https://docs.github.com/en/rest/reference/actions#list-workflow-runs-for-a-repository"""
237238
url = f'{GITHUB_API_URL}/actions/workflows/{workflow_id}/runs'
238239
headers = {'Accept': 'application/vnd.github.v3+json', 'Authorization': f'token {token}'}
239-
data = {'event': 'workflow_dispatch', 'branch': branch}
240+
data = {'event': 'workflow_dispatch', 'branch': branch, 'per_page': 5}
240241
with requests.get(url, headers=headers, data=json.dumps(data),
241-
stream=True, timeout=TIMEOUT) as response:
242+
stream=True, timeout=TIMEOUT_LONG) as response:
242243
logging.info("list_workflows: %s response: %s", url, response)
243244
return response.json()
244245

scripts/gha/print_matrix_configuration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@
166166
# gcloud firebase test ios models list
167167
TEST_DEVICES = {
168168
"android_min": {"type": "real", "device": "model=Nexus10,version=19"},
169-
"android_target": {"type": "real", "device": "model=gts4lltevzw,version=28"},
169+
"android_target": {"type": "real", "device": "model=blueline,version=28"},
170170
"android_latest": {"type": "real", "device": "model=oriole,version=33"},
171171
"emulator_min": {"type": "virtual", "image":"system-images;android-18;google_apis;x86"},
172172
"emulator_target": {"type": "virtual", "image":"system-images;android-30;google_apis;x86_64"},

0 commit comments

Comments
 (0)