Skip to content

Commit a139319

Browse files
authored
Remove validation test on inequality restrictions (#1474)
1 parent b50057e commit a139319

File tree

1 file changed

+0
-26
lines changed

1 file changed

+0
-26
lines changed

firestore/integration_test_internal/src/validation_test.cc

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -966,32 +966,6 @@ TEST_F(ValidationTest, QueryOrderByKeyBoundsMustBeStringsWithoutSlashes) {
966966
ErrorMessage(ErrorCase::kQueryInvalidBoundWithSlash));
967967
}
968968

969-
TEST_F(ValidationTest, QueriesWithDifferentInequalityFieldsFail) {
970-
EXPECT_ERROR(Collection()
971-
.WhereGreaterThan("x", FieldValue::Integer(32))
972-
.WhereLessThan("y", FieldValue::String("cat")),
973-
ErrorMessage(ErrorCase::kQueryDifferentInequalityFields));
974-
}
975-
976-
TEST_F(ValidationTest, QueriesWithInequalityDifferentThanFirstOrderByFail) {
977-
CollectionReference collection = Collection();
978-
std::string reason =
979-
ErrorMessage(ErrorCase::kQueryInequalityOrderByDifferentFields);
980-
EXPECT_ERROR(
981-
collection.WhereGreaterThan("x", FieldValue::Integer(32)).OrderBy("y"),
982-
reason);
983-
EXPECT_ERROR(
984-
collection.OrderBy("y").WhereGreaterThan("x", FieldValue::Integer(32)),
985-
reason);
986-
EXPECT_ERROR(collection.WhereGreaterThan("x", FieldValue::Integer(32))
987-
.OrderBy("y")
988-
.OrderBy("x"),
989-
reason);
990-
EXPECT_ERROR(collection.OrderBy("y").OrderBy("x").WhereGreaterThan(
991-
"x", FieldValue::Integer(32)),
992-
reason);
993-
}
994-
995969
TEST_F(ValidationTest, QueriesMustNotSpecifyStartingOrEndingPointAfterOrderBy) {
996970
CollectionReference collection = Collection();
997971
Query query = collection.OrderBy("foo");

0 commit comments

Comments
 (0)