Skip to content

Commit 91efa2a

Browse files
authored
Install Firebase tools locally, and skip if unneeded in desktop tests. (#1488)
* Install Firebase tools locally, and skip if unneeded in desktop tests. * Format. * Fix Windows paths. * Redo it via GITHUB_PATH instead of shell variables. * Programatically get npm directory. * Remove the removal * Add non-.bin path for Windows compatibility. * Fix yaml
1 parent 104dbfa commit 91efa2a

File tree

1 file changed

+20
-3
lines changed

1 file changed

+20
-3
lines changed

.github/workflows/integration_tests.yml

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -772,7 +772,12 @@ jobs:
772772
shell: bash
773773
timeout_minutes: 5
774774
max_attempts: 3
775-
command: npm install -g firebase-tools
775+
command: npm install firebase-tools
776+
- name: Add firebase-tools to PATH
777+
shell: bash
778+
run: |
779+
echo "$(npm root)" >> $GITHUB_PATH
780+
echo "$(npm root)/.bin" >> $GITHUB_PATH
776781
- name: Setup java
777782
uses: actions/setup-java@v3
778783
with:
@@ -1166,7 +1171,13 @@ jobs:
11661171
shell: bash
11671172
timeout_minutes: 5
11681173
max_attempts: 3
1169-
command: npm install -g firebase-tools
1174+
command: npm install firebase-tools
1175+
- name: Add firebase-tools to PATH
1176+
if: contains(needs.check_and_prepare.outputs.apis, 'firestore')
1177+
shell: bash
1178+
run: |
1179+
echo "$(npm root)" >> $GITHUB_PATH
1180+
echo "$(npm root)/.bin" >> $GITHUB_PATH
11701181
- name: Start Firestore Emulator
11711182
if: steps.device-info.outputs.device_type == 'virtual' && contains(needs.check_and_prepare.outputs.apis, 'firestore')
11721183
run: |
@@ -1287,7 +1298,13 @@ jobs:
12871298
shell: bash
12881299
timeout_minutes: 5
12891300
max_attempts: 3
1290-
command: npm install -g firebase-tools
1301+
command: npm install firebase-tools
1302+
- name: Add firebase-tools to PATH
1303+
if: contains(needs.check_and_prepare.outputs.apis, 'firestore')
1304+
shell: bash
1305+
run: |
1306+
echo "$(npm root)" >> $GITHUB_PATH
1307+
echo "$(npm root)/.bin" >> $GITHUB_PATH
12911308
- name: Start Firestore Emulator
12921309
if: contains(needs.check_and_prepare.outputs.apis, 'firestore')
12931310
run: |

0 commit comments

Comments
 (0)