Update to C++14. (#1250)

* Update CXX_STANDARD to 14.

* Add CMAKE_CXX_STANDARD_REQUIRED setting.

* Update C++ version in testapps.

* Upgrade to grpc 150 and C++ 14 for firestore (#1182)

* Upgrade to grpc 150 and C++ 14 for firestore

* Add firestore_dep_source to workflow

* Use C++14 make_unique

* Ensure CXX14

* Formatting

* CXX required in test

* C++14 for xcode project

* Ensures lineendings on windows so we can apply patch files

* Fix build error

* Add readme note about c++14.

* Remove C++ version warning header.

---------

Co-authored-by: wu-hui <[email protected]>

Author: jonsimantov

.github/workflows/integration_tests.yml

@@ -39,6 +39,8 @@ on:
         description: 'Optional: Packaging run # to build against?'
       test_pull_request:
         description: 'Optional: Pull request # to build and test? (With optional commit hash, separated by a colon. Specify the FULL hash.)'
+      firestore_dep_source:
+        description: 'Optional: Where to get firestore iOS SDK from: "RELEASED", "TIP" or "<git-commit> from firestore-ios-sdk"'
 
 env:
   triggerLabelPrefix: "tests-requested: "
@@ -330,6 +332,8 @@ jobs:
           if [[ "${{ github.event.schedule }}" == "0 11 * * *" ]]; then
             # at 3am PST/4am PDT. Running firestore desktop integration test aginst tip-of-tree ios repo
             additional_flags+=(--cmake_flag=-DFIRESTORE_DEP_SOURCE=TIP)
+          elif [[ "${{ github.event.inputs.firestore_dep_source }}" ]]; then
+            additional_flags+=(--cmake_flag=-DFIRESTORE_DEP_SOURCE=${{ github.event.inputs.firestore_dep_source }})
           fi
           python scripts/gha/build_testapps.py --p Desktop \
             --t ${{ needs.check_and_prepare.outputs.apis }} \

CMakeLists.txt

@@ -16,7 +16,8 @@
 
 cmake_minimum_required (VERSION 3.1)
 
-set (CMAKE_CXX_STANDARD 11)
+set (CMAKE_CXX_STANDARD 14)
+set (CMAKE_CXX_STANDARD_REQUIRED YES)  # Don't fall back to an earlier version.
 
 # Turn on virtual folders for visual studio
 set_property(GLOBAL PROPERTY USE_FOLDERS ON)

admob/integration_test/CMakeLists.txt

@@ -84,8 +84,9 @@ set(FIREBASE_INTEGRATION_TEST_SRCS
 # The include directory for the testapp.
 include_directories(src)
 
-# Integration test uses some features that require C++ 11, such as lambdas.
-set (CMAKE_CXX_STANDARD 11)
+# Firebase C++ SDK requires C++14.
+set (CMAKE_CXX_STANDARD 14)
+set (CMAKE_CXX_STANDARD_REQUIRED YES)  # Don't fall back to an earlier version.
 
 # Download and unpack googletest (and googlemock) at configure time
 set(GOOGLETEST_ROOT ${CMAKE_CURRENT_LIST_DIR}/external/googletest)

admob/src/include/firebase/admob.h

@@ -28,7 +28,6 @@
 #include "firebase/admob/rewarded_video.h"
 #include "firebase/admob/types.h"
 #include "firebase/app.h"
-#include "firebase/cpp_version_warning.h"
 #include "firebase/internal/common.h"
 
 #if !defined(DOXYGEN) && !defined(SWIG)

analytics/integration_test/CMakeLists.txt

@@ -84,8 +84,9 @@ set(FIREBASE_INTEGRATION_TEST_SRCS
 # The include directory for the testapp.
 include_directories(src)
 
-# Integration test uses some features that require C++ 11, such as lambdas.
-set (CMAKE_CXX_STANDARD 11)
+# Firebase C++ SDK requires C++14.
+set (CMAKE_CXX_STANDARD 14)
+set (CMAKE_CXX_STANDARD_REQUIRED YES)  # Don't fall back to an earlier version.
 
 # Download and unpack googletest (and googlemock) at configure time
 set(GOOGLETEST_ROOT ${CMAKE_CURRENT_LIST_DIR}/external/googletest)

analytics/src/include/firebase/analytics.h

@@ -23,7 +23,6 @@
 #include <string>
 
 #include "firebase/app.h"
-#include "firebase/cpp_version_warning.h"
 #include "firebase/future.h"
 #include "firebase/internal/common.h"
 #include "firebase/variant.h"

app/CMakeLists.txt

@@ -251,7 +251,6 @@ endif()
 
 set(internal_HDRS
     src/include/firebase/app.h
-        src/include/firebase/cpp_version_warning.h
     src/include/firebase/future.h
     src/include/firebase/internal/common.h
     src/include/firebase/internal/future_impl.h

app/integration_test/CMakeLists.txt

@@ -84,8 +84,9 @@ set(FIREBASE_INTEGRATION_TEST_SRCS
 # The include directory for the testapp.
 include_directories(src)
 
-# Integration test uses some features that require C++ 11, such as lambdas.
-set (CMAKE_CXX_STANDARD 11)
+# Firebase C++ SDK requires C++14.
+set (CMAKE_CXX_STANDARD 14)
+set (CMAKE_CXX_STANDARD_REQUIRED YES)  # Don't fall back to an earlier version.
 
 # Download and unpack googletest (and googlemock) at configure time
 set(GOOGLETEST_ROOT ${CMAKE_CURRENT_LIST_DIR}/external/googletest)

app/rest/CMakeLists.txt

@@ -15,7 +15,9 @@
 # CMake file for the firebase_rest_lib library
 
 cmake_minimum_required (VERSION 3.1)
-set (CMAKE_CXX_STANDARD 11)
+# Firebase C++ SDK requires C++14.
+set (CMAKE_CXX_STANDARD 14)
+set (CMAKE_CXX_STANDARD_REQUIRED YES)  # Don't fall back to an earlier version.
 
 project(firebase_rest_lib NONE)
 enable_language(C)

app/src/include/firebase/app.h

@@ -17,7 +17,6 @@
 #ifndef FIREBASE_APP_SRC_INCLUDE_FIREBASE_APP_H_
 #define FIREBASE_APP_SRC_INCLUDE_FIREBASE_APP_H_
 
-#include "cpp_version_warning.h"
 #include "firebase/internal/platform.h"
 
 #if FIREBASE_PLATFORM_ANDROID