Skip to content

Commit 34da503

Browse files
committed
Updated release notes and added more info in source comments.
1 parent f321bf9 commit 34da503

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

cmake/binary_to_array.cmake

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,12 @@
1717
#
1818
# Args:
1919
# NAME: The name to use for the generated files.
20-
# INPUT: The input binary to embed into the source file.
20+
# INPUT: The input binary to embed into the source file. Please ensure that
21+
# the input binary is uniquely named across all embedded resources used
22+
# in the project. This is because the generated C++ source files strip
23+
# out the directories which can cause conflicts when caching these
24+
# embedded resources in the C++ layer (observed on Android API <= 21).
25+
# See https://github.com/firebase/firebase-cpp-sdk/pull/289.
2126
# CPP_NAMESPACE: The namespace to use in the generated files.
2227
# OUTPUT_DIRECTORY: Where the generated files should be written to.
2328
function(binary_to_array NAME INPUT CPP_NAMESPACE OUTPUT_DIRECTORY)

release_build_files/readme.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -571,6 +571,12 @@ code.
571571

572572
## Release Notes
573573

574+
### 7.1.1
575+
- Changes
576+
- General (Android): Use non-conflicting file names for embedded resources
577+
in Android builds. This fixes segfault crashes on old Android devices
578+
(Android 5 and below).
579+
574580
### 7.1.0
575581
- Changes
576582
- General (iOS): Re-enabled Bitcode in iOS builds

0 commit comments

Comments
 (0)